Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Version Number - Move Out of DataverseServiceBean #1579

Closed
mheppler opened this issue Mar 4, 2015 · 3 comments
Closed

App Version Number - Move Out of DataverseServiceBean #1579

mheppler opened this issue Mar 4, 2015 · 3 comments
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure"

Comments

@mheppler
Copy link
Contributor

mheppler commented Mar 4, 2015

No description provided.

@mheppler mheppler added the Component: Code Infrastructure formerly "Feature: Code Infrastructure" label Mar 4, 2015
@mheppler mheppler added this to the In Review - 4.0.x milestone Mar 4, 2015
posixeleni added a commit that referenced this issue Mar 5, 2015
@scolapasta scolapasta removed their assignment Jan 27, 2016
@scolapasta scolapasta removed this from the Not Assigned to a Release milestone Jan 28, 2016
@pdurbin
Copy link
Member

pdurbin commented Feb 11, 2016

@mheppler since you opened this issue are you particularly invested in it? Would you like to see it go through QA? I ask because @bencomp created a pull request (almost a month ago) for it at #2877. If you feel like it, you could get on that branch and see if everything looks ok to you.

@mheppler
Copy link
Contributor Author

Pretty sure the lack of detail in that initial comment on this one reflects the amount I am invested. If I had to guess, this was a feature that I requested, it got thrown into the app during 4.0-haste, and @scolapasta said, "create a ticket to review this, so that we don't forget, and do something better with it."

@pdurbin
Copy link
Member

pdurbin commented Feb 11, 2016

@mheppler yeah, that's what I was thinking too. You probably volunteered to enter tickets during a meeting long ago or something. I've done the same.

scolapasta added a commit that referenced this issue Feb 29, 2016
Refactor use of DataverseServiceBean.getApplicationVersion (fixes #1579)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure"
Projects
None yet
Development

No branches or pull requests

3 participants