Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revisit indexing of Publication Status facet (publicationStatus Solr field) #2377

Closed
pdurbin opened this issue Jul 21, 2015 · 3 comments
Closed

revisit indexing of Publication Status facet (publicationStatus Solr field) #2377

pdurbin opened this issue Jul 21, 2015 · 3 comments
Assignees
@kcondon
Labels
Feature: Search/Browse
Milestone
4.1

Comments

@pdurbin
Copy link
Member

pdurbin commented Jul 21, 2015

In Solr we index an array of "publicationStatus" values which can have multiples such as both "Draft" and "Unpublished" but we don't index "Deaccessioned" as one of these values.

We did things this way because of a decision in summer 2014 to "Show a 'Deaccessioned' label on the dataset card but don't show a facet" and there is some lively debate in comments: https://docs.google.com/document/d/1lFcwjtdGIqqQLYYnwtTI2GZNzmzYlrnMk2omGcXO9oY/edit?usp=sharing

We're thinking about revisiting this decision. At minimum we think we want to start indexing "Deaccessioned" as a possible value for "publicationStatus" so it can be operated on by MyData (#2302 says "Add in review and deaccession statuses for datasets"). (In review is a whole discussion in and of itself.)
@pdurbin pdurbin self-assigned this Jul 21, 2015
@pdurbin pdurbin added this to the 4.1 milestone Jul 21, 2015
pdurbin added a commit that referenced this issue Jul 21, 2015
@pdurbin
index and show deaccessioned facet #2377
824c4b0
@pdurbin
Copy link
Member Author

pdurbin commented Jul 21, 2015

@eaquigley I made the small change we talked about to start indexing and showing "Deaccessioned" as one of the possible values for "Publication Status" in 824c4b0 . It follows the same rules as "Draft" and "Unpublished" in that the entire "Publication Status" facets is hidden unless there are there are cards that are in an unpublished, draft, or deaccessioned state. To see the change you'll need a build newer than v. 4.1 build 52. I'm giving this to you to talk with @scolapasta @mheppler @mcrosas etc. about what we want. The change I made was small and we can easily back out of it.

@pdurbin pdurbin assigned eaquigley and unassigned pdurbin Jul 21, 2015
@pdurbin pdurbin mentioned this issue Jul 21, 2015
Closed
2 tasks
@pdurbin
Copy link
Member Author

pdurbin commented Jul 21, 2015

As discussed in a review meeting, we're fine with this change. There's a related ticket to show deaccessioned in MyData at #2382. Passing to QA. Please note that the change requires reindexing.

@kcondon kcondon self-assigned this Jul 21, 2015
@kcondon
Copy link
Contributor

kcondon commented Jul 22, 2015

OK, deaccessioned facet is working, shows datasets that would normally appear according to the search/index rules. Closing.

@kcondon kcondon closed this as completed Jul 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
Feature: Search/Browse
Projects
None yet
Milestone
4.1
Development

No branches or pull requests
3 participants
@pdurbin @kcondon @eaquigley