Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guides - Missing Navbar Links in Header #2750

Closed
pdurbin opened this issue Nov 19, 2015 · 4 comments
Closed

Guides - Missing Navbar Links in Header #2750

pdurbin opened this issue Nov 19, 2015 · 4 comments
Assignees
@kcondon
Milestone
4.2.2

Comments

@pdurbin
Copy link
Member

pdurbin commented Nov 19, 2015

As originally noted by @eaquigley at https://trello.com/c/aKUM82XA/11-navigation-consistent-for-guides-dataverse-org-best-practices-dataverse-org-and-dataverse-org ever since we switched from the Django version of http://dataverse.org to OpenScholar in late September the header at http://guides.dataverse.org has been missing.

Firebug indicates that's the page is failing to fetch URLs like http://dataverse.org/nav-only-json/?callback=jsonp1447942170901 which used to exist in the Django site:

screen shot 2015-10-28 at 10 39 35 am

@raprasad and @mheppler originally set this up so I'm going to give it to one of them for investigation for now.

I should note that http://best-practices.dataverse.org and http://community.dataverse.org suffer from the same issue for the same reason. That code is in a different repo however: https://github.com/IQSS/dataverse.org/tree/master/docs
@pdurbin
Copy link
Member Author

pdurbin commented Nov 19, 2015

Actually, it sounds like we're moving to readthedocs ( https://trello.com/b/NPAE4dNU/user-guides-dataverse ) so this will probably become a non-issue.

@mheppler mheppler changed the title missing header on the guides Guides - Missing Navbar Links in Header Nov 30, 2015
@mheppler
Copy link
Contributor

The guides should have the same navbar links that are found on the Dataverse Project site.

screen shot 2015-11-30 at 3 34 22 pm

It is probably the best solution to go back to a static navbar, and not worry about having to maintain multiple navbar links in multiple guides sites.

@mercecrosas mercecrosas modified the milestone: In Review Nov 30, 2015
@mheppler mheppler modified the milestones: 4.2.2, Not Assigned to a Release Nov 30, 2015
mheppler added a commit that referenced this issue Nov 30, 2015
@mheppler
Replaced dynamic guide navbar solution for the guides with a static v…
d989a26 
…ersion to fix missing links. [ref #2750]
@mheppler
Copy link
Contributor

Replaced dynamic navbar solution for the guides with a static version to fix missing links.

screen shot 2015-11-30 at 5 00 03 pm

@mheppler mheppler assigned kcondon and unassigned mheppler Nov 30, 2015
@kcondon
Copy link
Contributor

kcondon commented Dec 1, 2015

OK, tested, works, closing.

@kcondon kcondon closed this as completed Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.2.2
Development

No branches or pull requests
4 participants
@pdurbin @mercecrosas @mheppler @kcondon