Potential fix but need to make this roleAssigneeService.getUserGroups method by @sekmiller public and see what @michbarsinai thinks:

    logger.info("BEGIN finding explicit groups for " + user.getIdentifier());
    List<String> explicitGroups = roleAssigneeService.getUserGroups(user.getIdentifier().substring(1));
    for (String string : explicitGroups) {
        logger.info("found explicit group: " + string);
        sb.append(" OR ");
        sb.append(IndexServiceBean.getGroupPrefix() + string);
        groupsFromProviders = sb.toString();
    }
    logger.info("END finding explicit groups for " + user.getIdentifier());

All this would go after calling Set<Group> groups = groupService.groupsFor(au, groupsForDvObjectParamCurrentDataverse); in SearchServiceBean: https://github.com/IQSS/dataverse/blob/v4.3/src/main/java/edu/harvard/iq/dataverse/search/SearchServiceBean.java#L851

@michbarsinai I'm wondering if we can have a groupService.groupsFor(au) method where we get back all the user's groups, without having to pass in a dataverse like the method above.

@pdurbin If you pass groupService.groupsFor(au, null) you get all groups assigned to the authenticated user. I used the method that way for shib/ip groups.

We could, but note that ExplicitGroups are defined in a context of a Dataverse. So you would not get ALL the groups.

On 4 Apr 2016, at 23:47, Philip Durbin notifications@github.com wrote:

Potential fix but need to make this roleAssigneeService.getUserGroups method by @sekmiller https://github.com/sekmiller public and see what @michbarsinai https://github.com/michbarsinai thinks:

logger.info("BEGIN finding explicit groups for " + user.getIdentifier());
List<String> explicitGroups = roleAssigneeService.getUserGroups(user.getIdentifier().substring(1));
for (String string : explicitGroups) {
    logger.info("found explicit group: " + string);
    sb.append(" OR ");
    sb.append(IndexServiceBean.getGroupPrefix() + string);
    groupsFromProviders = sb.toString();
}
logger.info("END finding explicit groups for " + user.getIdentifier());

All this would go after calling Set groups = groupService.groupsFor(au, groupsForDvObjectParamCurrentDataverse); in SearchServiceBean: https://github.com/IQSS/dataverse/blob/v4.3/src/main/java/edu/harvard/iq/dataverse/search/SearchServiceBean.java#L851 https://github.com/IQSS/dataverse/blob/v4.3/src/main/java/edu/harvard/iq/dataverse/search/SearchServiceBean.java#L851
@michbarsinai https://github.com/michbarsinai I'm wondering if we can have a groupService.groupsFor(au) method where we get back all the user's groups, without having to pass in a dataverse like the method above.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #3055 (comment)

But it would work for shib/ip groups since they are not in the context of a dv?

Shib should be there. IP groups won't, since they are determined by the IP address of the DataverseQuery.

On 4 Apr 2016, at 23:57, Stephen Kraffmiller notifications@github.com wrote:

But it would work for shib/ip groups since they are not in the context of a dv?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #3055 (comment)

@michbarsinai @sekmiller @scolapasta I implemented a fix in pull request #3062. Code review is very welcome!

I'm passing this issue to QA.

This works now, closing.

Pull request #3062 now has merge conflicts. Reopening this issue and giving to @scolapasta for prioritization.

I resolved the merge conflicts in pull request #3062 and updated the branch to include the fix I made in pull request #3124 which resolves the user id mismatch mystery. Passing to QA.

To be clear, the fix is in pull request #3062 which is the 3055-get-more-groups branch.