primary code change

File to change: https://github.com/IQSS/shared-dataverse-information/blob/master/shared_dataverse_information/dataverse_info/models.py

1. Change dataset_citation:
   • Original: dataset_citation = models.CharField(max_length=255)
   • Updated: dataset_citation = models.TextField()
2. Add a test, including a non-English language test
3. Update the changelog, version, etc within the library

steps after change is made and checked in:

shared dataverse information

• code base: https://github.com/IQSS/shared-dataverse-information

• Update this library in pypi to version 0.5.6:

  • https://pypi.python.org/pypi/shared_dataverse_information/0.5.5

Geoconnect

• Update the requirements file in geoconnect:
  • https://github.com/IQSS/geoconnect/blob/master/requirements/base.txt#L1
• Update the geoconnect migrations and save in github
• Run the migrations:
  • On geoconnect dev (heroku)
  • On geoconnect prod (heroku)

WorldMap

• Update the requirements file in the worldmap legacy branch:
  • https://github.com/cga-harvard/cga-worldmap/blob/legacy/shared/requirements.txt#L69
• Open a pull request and have WM team update:
  • shared_dataverse_information library
  • update the database column

Note 1: WorldMap should be updated before geoconnect on dev/prod

Note 2: Checked the 3 codebases* that dataset_citation size doesn't appear on any validation forms, etc. e.g., the model size (currently 255) is used for any validation. * (shared_dataverse_information, geoconnect, worldmap)

We discussed this issue at standup this morning and I floated the idea of doing the "partial fix" described above of truncating the citation on the WorldMap side. It sounds like we don't want this so it would be a waste of effort. I guess I'll leave this issue assigned to me for now because I'd like to see if I can add a failing test.

Speaking of tests, I also added tests as part of #3489 but they are not automatically executed so they could start failing at any time. Since we're already using https://travis-ci.org/IQSS for Dataverse and Zelig, we should probably attempt to figure out how to add a Django app to Travis and run the tests automatically. I did a quick search for this but it seems somewhat involved: https://docs.travis-ci.com/user/languages/python/

I'm blocked on this issue because I can't get WorldMap installed so I'm unassigning myself. The error I'm seeing is at the paver build step: IQSS/worldmap-legacy-dev@fc81368#commitcomment-21735918

• dataverse codebase update to pass datafile.is_restricted value
  • Add to API endpoint. Required for GeoConnnect: Can map restricted files and restrict mapped files but anyone can download from WorldMap #3636
• shared dataverse information repository update
• geoconnect repository update
  • Run: heroku run 'python manage.py migrate --settings=geoconnect.settings.heroku'
  • geoconnect dev db update (updated requirements)
  • geoconnect prod db update (updated requirements)
• worldmap repository update
  • worldmap prod db update (updated requirements)
    • May require manual db updates!

Code updated on 2/4 repositories. and 2/4 servers

Last commit is a 1-liner for the dataverse codebase

pull requested add to worldmap codebase: cga-harvard/geonode#228

Testing

• Create a dataset where the citation is over 255 characters
• Add a mappable file (e.g. shapefile)
• Check if the citation is carried to the final map. Currently, WorldMap returns a non-descript error b/c of a 255 char limit on the citation size

Status:

• can code review:
  • Dataverse code. connects to #3432 : WorldMap: Dataset citations longer than 255 chars cause an error #3772
  • Geoconnect code
    QA
• Pull request in for WorldMap change. Will coordinate when that is in--then the ticket can go to QA

It looks like IQSS/geoconnect#129 was already merged. cga-harvard/geonode#228 hasn't but looks fine. #3772 is small and looks good. I'm moving this to QA at https://waffle.io/IQSS/dataverse

@kcondon will you let know when WorldMap code has been deployed for testing

How to test (from comment above):

• Create a dataset where the citation is over 255 characters
• Add a mappable file (e.g. shapefile)
• Check if the citation is carried to the final map. Currently, WorldMap returns a non-descript error b/c of a 255 char limit on the citation size