Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Replace: the UNF of the version doesn't get recalculated, when replacing a tabular file with a non-tabular. #3625

Closed
kcondon opened this issue Feb 6, 2017 · 2 comments
Closed

File Replace: the UNF of the version doesn't get recalculated, when replacing a tabular file with a non-tabular. #3625

kcondon opened this issue Feb 6, 2017 · 2 comments
Assignees
@kcondon
Milestone
4.6.1 - ORCID and...

Comments

@kcondon
Copy link
Contributor

kcondon commented Feb 6, 2017 •
edited by djbrooke

Found using new data integrity endpoint, thanks Phil!

If I use the new file replace feature to replace a tabular file with non-tabular file, ie. .txt file, the UNF remains in the citation when it shouldn't and gets picked up by the data integrity endpoint.

If the file is replaced by a different tabular file the UNF is recalculated.

Putting in v4.6.1 for consideration
@kcondon kcondon added this to the 4.6.1 - ORCID and File Replace milestone Feb 6, 2017
@djbrooke djbrooke added the ready label Feb 6, 2017
@kcondon kcondon changed the title File Replace: Replacing a tabular file with a non-tabular file or another tabular file with different UNF leaves old UNF in citation. File Replace: Replacing a tabular file with a non-tabular file leaves UNF in citation. Feb 6, 2017
@djbrooke djbrooke added in progress and removed ready labels Feb 8, 2017
@landreev landreev added in progress and removed ready labels Mar 1, 2017
@landreev landreev self-assigned this Mar 1, 2017
landreev added a commit that referenced this issue Mar 1, 2017
@landreev
this is a fix for #3625 - recalculate the UNF of the version, when re…
3c80799 
…placing a tabular file.
@landreev landreev changed the title File Replace: Replacing a tabular file with a non-tabular file leaves UNF in citation. File Replace: the UNF of the version doesn't get recalculated, when a tabular file gets replaced with a non-tabular. Mar 2, 2017
@landreev landreev changed the title File Replace: the UNF of the version doesn't get recalculated, when a tabular file gets replaced with a non-tabular. File Replace: the UNF of the version doesn't get recalculated, when replacing a tabular file with a non-tabular. Mar 2, 2017
@landreev landreev mentioned this issue Mar 2, 2017
Merged
11 tasks
@landreev
Copy link
Contributor

landreev commented Mar 2, 2017

created a pull request: #3664

@landreev landreev changed the title File Replace: the UNF of the version doesn't get recalculated, when replacing a tabular file with a non-tabular. File Replace: Replacing a tabular file with a non-tabular file leaves UNF in citation. Mar 2, 2017
@landreev landreev removed their assignment Mar 2, 2017
@landreev landreev changed the title File Replace: Replacing a tabular file with a non-tabular file leaves UNF in citation. File Replace: the UNF of the version doesn't get recalculated, when replacing a tabular file with a non-tabular. Mar 2, 2017
@landreev
Copy link
Contributor

landreev commented Mar 2, 2017

@kcondon
Notes on QA for this issue:
The fix is very straightforward. But since this has to do with UNFs, it needs to be tested extra carefully. I tried to test all sorts of different scenarios - for example, replacing 1 of many tabular files with a non-tabular, making sure the UNF goes to what it should be for the remaining files; replacing the single tabular file with a non-tabular - making sure the UNF changes to null. Also, like with pretty much everything else all the test scenarios have to be tried separately, once on a published dataset with no drafts, and once on a published dataset with a draft version already existing... Please re-test all these, and whatever other scenarios you can think of, in case I still missed anything...

@scolapasta scolapasta self-assigned this Mar 3, 2017
@scolapasta scolapasta changed the title File Replace: the UNF of the version doesn't get recalculated, when replacing a tabular file with a non-tabular. File Replace: the UNF of the version doesn't get recalculated, when replacing a tabular file with a non-tabular. Mar 3, 2017
@scolapasta scolapasta removed their assignment Mar 3, 2017
@kcondon kcondon self-assigned this Mar 7, 2017
@kcondon kcondon closed this as completed Mar 8, 2017
@kcondon kcondon removed the Status: QA label Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.6.1 - ORCID and File Replace
Development

No branches or pull requests
4 participants
@landreev @scolapasta @kcondon @djbrooke