Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Download w/ Rsync UI/Workflow changes #3998

Closed
pameyer opened this issue Jul 12, 2017 · 23 comments
Closed

File Download w/ Rsync UI/Workflow changes #3998

pameyer opened this issue Jul 12, 2017 · 23 comments
Assignees

Comments

@pameyer
Copy link
Contributor

pameyer commented Jul 12, 2017

Download compliment to #3348 .

Backend dependency on #3561

@mheppler
Copy link
Contributor

mheppler commented Jul 12, 2017

UI IMPACT

As defined in the following mockup document.

Dataverse

  • Render logic to hide Metrics block
  • Render logic to hide Guestbook link in Edit dropdown

Dataset (view/no files)

  • Render logic to hide Metrics block
  • Render logic to hide Guestbook panel in Terms tab

Dataset (view/has file/success-upload)

  • Render logic to hide Download count
  • Render logic to hide Download button
  • Help text with link to User Guide (/user/dataset-management.html#file-handling-and-uploading)
  • Display (in place of Download button) "Local Access" path, "Download Access" rsync commands for various locations (with location name country in parentheses), "Verify Data" command
  • Dynamic path for Local Access
  • Dynamic paths for Download Access
  • Dynamic command for Verify Data
  • Tooltips for "Local Access", "Download Access", "Verify Data" labels
  • Style code snippets as "black text, grey background" (already delivered in File Upload w/ Rsync UI/Workflow changes #3348)

Edit Dataset Terms

  • Render logic to hide Guestbook panel

File

  • Render logic to hide Metrics block
  • Render logic to hide Download count
  • Render logic to hide Download button
  • New "Data Access" tab, displayed first, with help msg and labels/values to display "Local Access" path, "Download Access" rsync commands for various locations (with location name country in parentheses), "Verify Data" command
  • Dynamic path for Local Access
  • Dynamic paths for Download Access
  • Dynamic command for Verify Data
  • Help text with link to User Guide (/user/dataset-management.html#file-handling-and-uploading)
  • Tooltips for "Local Access", "Download Access", "Verify Data" labels
  • Style code snippets as "black text, grey background" (already delivered in File Upload w/ Rsync UI/Workflow changes #3348)

User Guide

  • Rsync Download > File Handling + Uploading > Dataset + File Management

@pameyer
Copy link
Contributor Author

pameyer commented Jul 26, 2017

From another round of testing:

  • hide "guestbook" block under terms tab; since "package files" and guestbooks are not intended to work together.

@dlmurphy
Copy link
Contributor

dlmurphy commented Aug 1, 2017

Wrote some new messaging for the rsync download pages, would love to get @pameyer's verification that everything is accurate. Here are some earlier mockups, followed by the revised instructional text.

Data Access tab at the bottom of the file page:

dataaccess
There will be gray help text at the top, and tooltips on each of the three blue headers.

Gray instructions at top: "This data can be accessed through your computer's Terminal using the commands below. For more information, see our User Guide." ("User Guide" links to a guide page with more info)

Local Access tooltip: "If this data is locally available, this is its file path."

Download Access tooltip: "Download this data by running this command from your preferred mirror."

Verify Data tooltip: "This command runs a checksum to verify the integrity of the data you've downloaded."


File table at the bottom of the dataset page:

filetable
This page will use the exact same help text as the other page. As discussed with @mheppler and @TaniaSchlatter, the gray general instructions should go on the right side of the file table, above "Local Access". The three headers will have the same tooltips as the headers on the file page.

Text styling

All red-on-pink text should be changed to highlighted black text, as in this earlier mockup:
font2

@pameyer
Copy link
Contributor Author

pameyer commented Aug 1, 2017

@dlmurphy looks good to me

@pameyer
Copy link
Contributor Author

pameyer commented Aug 28, 2017

One update - these UI changes should be conditional on the downloadMethods setting that was previously added (for this purpose).

dlmurphy added a commit that referenced this issue Aug 28, 2017
First draft of the rsync download section.
@landreev
Copy link
Contributor

It doesn't say so in the checklist explicitly, but, there is no "Download" button on the page for a package file, correct? (just to confirm). I.e., that "Data Access" text on the dataset page, in the mockup above, replaces the current Download button - correct?

If so, the checklist really should say "render logic to hide download count AND download button"...

@landreev
Copy link
Contributor

landreev commented Aug 29, 2017

It sounds so far like this issue is mostly about changing the rendering of the dataset and other pages for "package" files.
So then, in order to work on it, you just need a file with the "package" mime type. One way of creating such a file - aside from actually running a successful DCM upload - would be to pick a dataset with a single file; find the file in the DataFile Postgres table; and change the ContentType field to application/vnd.dataverse.file-package.

(and, it sounds like, you don't need this Datafile to contain an actual physical package directory on the filesystem; at least not for the purposes of working on the page...)

@pameyer
Copy link
Contributor Author

pameyer commented Aug 29, 2017

@landreev - you are correct; there shouldn't be a "Download" button

@dlmurphy dlmurphy removed their assignment Aug 29, 2017
@mheppler mheppler removed their assignment Aug 29, 2017
mheppler added a commit that referenced this issue Sep 20, 2017
…er logic to only display it on dataset pg when dataset is unpublished. [ref #3998]
@dlmurphy dlmurphy removed their assignment Sep 20, 2017
@dlmurphy dlmurphy self-assigned this Sep 20, 2017
dlmurphy added a commit that referenced this issue Sep 20, 2017
Clarified phrasing of upload files instructions to be more clear and
match the upload script.
@dlmurphy dlmurphy removed their assignment Sep 20, 2017
@landreev
Copy link
Contributor

I may have been able to fix that annoying "CSS blink after the page auto-refreshes" issue. (the "blink" itself was a Chrome-only issue; but the auto-refresh was also causing the files table to be resized incorrectly, and that was affecting all (or most) browsers. I've updated the checklist entry).

It was all caused by the "update=@ALL" in the autorefresh block. It's just that for whatever reason I couldn't get it to properly refresh all the affected page parts without resorting to "all", back when I was working on it for tabular ingest. (so, this was not anything introduced in these rsync branches; we've had this issue forever).

But, as I said, I think I got it to work, by updating just the affected components (the files table; the citation; the edit/publish/etc. buttons; and the message panel). But please re-test carefully. And see if I missed anything.

rbhatta99 added a commit that referenced this issue Sep 20, 2017
matthew-a-dunlap added a commit that referenced this issue Sep 20, 2017
Remove 'duplicated' in-review notification
Set workflow complete notification to notify for correct roles
Moved role-adding notification to happen after publish success/notification
Minor refactoring.
@landreev
Copy link
Contributor

screen shot 2017-09-21 at 11 57 20 am

@pdurbin pdurbin self-assigned this Sep 21, 2017
@pdurbin pdurbin removed their assignment Sep 21, 2017
@landreev
Copy link
Contributor

Wait, my commit with the message fix didn't seem to go through. Trying again.

@landreev
Copy link
Contributor

@kcondon I've added a similar success message to file delete on the single file page as well.

@sekmiller sekmiller removed their assignment Sep 25, 2017
rbhatta99 added a commit that referenced this issue Sep 25, 2017
@kcondon kcondon closed this as completed Sep 25, 2017
@djbrooke djbrooke modified the milestones: 4.9 - Large Data Upload Integration, 4.8 - AWS S3 Support Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants