This includes:

• make the Upload Files pg scalable for any combination of HTTP, dropbox, rsync+ssh, or any other config options we develop down the road
• the file upload workflow for rsync only will need to change, to use the Upload Files pg and not just the Upload Files popup, to be more consistent across the various config options
• for this initial phase of delivering "dual-mode", you will only be able to upload one way or another, HTTP/Dropbox or rsync+ssh, but not both
• download methods will depend on which upload method was used
• dataset lock will continue to be applied when the rsync script is downloaded, which displays the lock warning msg on the Upload Files pg -- you will not be able to return to the Upload Files pg once you leave it, because the dataset lock feature currently disables the Upload Files button

Initial commit for UI prototype added to branch 4610-upload-dual-mode. Changes include:

• New accordion panel UI for various upload method options
• Placeholder panel headers, help text, etc
• Fixed trailing hyphen issue in help msg block outlined in Info Message Block - Fix format/style issue (see: trailing hyphen) #4608
• New "Done" button added to editdatafiles.xhtml when the page is empty/no file/nothing to save

Tasks to tackle in the next phase of development:

• Proper render logic for dropbox and rsync panels
• Final help text for panels, added to bundle
• Investigate bug for new "Done" button on editdatafiles.xhtml when you delete uploaded files from the table
• Investigate use of element id's in commandButtons on Lines 296-297 of editFilesFragment.xhtml, does not seem scalable, and not sure if I added all the new UI id's to all the buttons that need them (see delete bug above?)
• Write help/error/success msg text for all the various render conditions related to what upload options are available and when (note: you can not upload via rsync if you have already uploaded files via http, and vice versa)

This probably needs it's own issue, but the documentation for how to set up Dropbox for file upload is severely lacking. It took me far too long to find these required steps in the Dropbox documentation. We should link to that page from our guides to make it easier to set up. Currently, we provide no instructions.

3db4486 was so far develop that I couldn't even run the code so I merged the lastest in fb4e4f3. Heads up to @dlmurphy that I went with the version of @mheppler 's branch, which will undo fe59aef so you two should get on the same page about that tooltip.

@pdurbin, I just talked with @mheppler and we're good with that merge. That tooltip will likely be further edited in the near future as part of the 5.0 redesign process anyway.

Wanted to add some additional information about the 827072f commit above -- "Improved render logic for filesTable on editFilesFragment to only show with empty msg if a file was deleted in the Edit File view".

Once upon a time, the editFilesFragment was made to be an include that could be used on more than one page (7c7e1e0). I believe there may have been some render logic related to authentication in the filesTable dataTable that was a remnant and was no longer needed.

#{(datasetPage or (dataverseSession.user.authenticated and permissionsWrapper.canIssueUpdateDatasetCommand(EditDatafilesPage.dataset)))}

The rsync upload workflow does not require this dataTable to be displayed with the emptyMessage "Files you upload will appear here." The changes to dual-mode brought that msg back into rsync-only and is also not required in dual mode. So new render logic was added to the table, removing the unnecessary authentication render logic as well as the logic to always display it on the dataset pg.

#{!empty EditDatafilesPage.fileMetadatas or !EditDatafilesPage.showFileUploadFragment()}

This new render logic only displays the dataTable when it is empty in the Edit Files workflow after you have deleted every file(s) displayed in the table, which then displays the proper "There are no selected files to display" as the emptyMessage.

Edit Files:

Create Dataset:

With my latest check in you can delete a file in the Edit Metadata workflow. IF the list of files is empty the buttons will not revert to "Done" because you must press "Save Changes" complete the delete. Or "Cancel" if you change your mind. Again.