Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guestbook: When downloading from file landing page, name field is not autopopulated, not referenced when writing gb and not enforced #4696

Closed
kcondon opened this issue May 18, 2018 · 0 comments
Closed

Guestbook: When downloading from file landing page, name field is not autopopulated, not referenced when writing gb and not enforced #4696

kcondon opened this issue May 18, 2018 · 0 comments
Assignees
@kcondon
Labels
Feature: Guestbook Type: Bug a defect
Milestone
4.10 - Additional...

Comments

@kcondon
Copy link
Contributor

kcondon commented May 18, 2018 •
edited by jggautier

The guestbook popup has an issue when downloading from the file landing page. It does not prefill the name field if logged in, does not use any entered value (uses username if logged in or guest if not), and does not enforce the field if required (guessing because it already has a value it uses).

I believe this issue was recently resolved for the dataset page download (#4393).
sekmiller added a commit that referenced this issue Oct 24, 2018
@sekmiller
#4696 Fix name reference in popup
4cf0c0a
@sekmiller sekmiller self-assigned this Oct 24, 2018
@sekmiller sekmiller mentioned this issue Oct 24, 2018
Merged
5 tasks
@sekmiller sekmiller removed their assignment Oct 24, 2018
@kcondon kcondon self-assigned this Oct 29, 2018
kcondon added a commit that referenced this issue Oct 31, 2018
@kcondon
Merge pull request #5232 from IQSS/4696-fix-download-popup
8fb0c7a 
#4696 Fix name reference in popup
@kcondon kcondon closed this as completed Oct 31, 2018
@jggautier jggautier mentioned this issue Mar 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
Feature: Guestbook Type: Bug a defect
Projects
None yet
Milestone
4.10 - Additional Data Transfer Options
Development

No branches or pull requests
5 participants
@pdurbin @sekmiller @kcondon @djbrooke @jggautier