Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error handling #4882

Closed
pameyer opened this issue Jul 23, 2018 · 3 comments
Closed

Better error handling #4882

pameyer opened this issue Jul 23, 2018 · 3 comments
Assignees
@kcondon
Milestone
4.9.2 - Stata Upg...

Comments

@pameyer
Copy link
Contributor

pameyer commented Jul 23, 2018

Having the dataset persistent ID as a GET parameter to the dataset page can result in 500 errors when $pid is interpretable by postgres.
@pdurbin
Copy link
Member

pdurbin commented Jul 23, 2018

@pameyer if you're curious about how we remove .xhtml from URLs, see dfe0488 for an example from src/main/webapp/WEB-INF/pretty-config.xml

PIDs are especially challenging because they have slashes in them. When we added the ability to target a dataset using a PID rather than a database id in #1837 we used a (GET) query parameter.

@djbrooke djbrooke changed the title consider switching dataset.xhtml?persistentId=$pid to /dataset/$pid Better error handling Jul 25, 2018
@pdurbin pdurbin self-assigned this Jul 26, 2018
pdurbin added a commit that referenced this issue Jul 26, 2018
@pdurbin
better error handling #4882
a1e9e50
@pdurbin pdurbin mentioned this issue Jul 26, 2018
Merged
@pdurbin
Copy link
Member

pdurbin commented Jul 26, 2018

I just created pull request #4898 and moved this issue to code review at https://waffle.io/IQSS/dataverse

@pdurbin pdurbin removed their assignment Jul 26, 2018
@sekmiller sekmiller self-assigned this Jul 27, 2018
@sekmiller sekmiller removed their assignment Jul 27, 2018
@kcondon kcondon self-assigned this Jul 27, 2018
@kcondon
Copy link
Contributor

kcondon commented Jul 30, 2018

Under the test scenario I was given, this issue still occurs. Passing back to Dev. See me or pete for test scenario.

@kcondon kcondon assigned pdurbin and unassigned kcondon Jul 30, 2018
sekmiller added a commit that referenced this issue Aug 1, 2018
@sekmiller
#4882 add test to ParseGlobalId
18a216b
@sekmiller sekmiller removed their assignment Aug 1, 2018
@kcondon kcondon self-assigned this Aug 1, 2018
kcondon added a commit that referenced this issue Aug 1, 2018
@kcondon
Merge pull request #4898 from IQSS/4882-error-handling
3dea1ae 
better error handling #4882
@kcondon kcondon closed this as completed Aug 1, 2018
@kcondon kcondon removed the Status: QA label Aug 1, 2018
@djbrooke djbrooke added this to the 4.9.2 - Stata Upgrades, etc. milestone Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.9.2 - Stata Upgrades, etc.
Development

No branches or pull requests
6 participants
@pdurbin @sekmiller @kcondon @djbrooke @matthew-a-dunlap @pameyer