Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata Customization : add a note about setup #5205

Closed
rmo-cdsp opened this issue Oct 17, 2018 · 9 comments
Closed

Metadata Customization : add a note about setup #5205

rmo-cdsp opened this issue Oct 17, 2018 · 9 comments

Comments

@rmo-cdsp
Copy link
Contributor

Add a note in the Metadata Customization part in the guide about the way the dataset fields are setup in the app. Thanks to @pdurbin , I now know that the script https://github.com/IQSS/dataverse/blob/v4.9.4/scripts/api/setup-datasetfields.sh , used by the installer script, define this. This information may be useful in the guide to understand this.

@pdurbin
Copy link
Member

pdurbin commented Oct 17, 2018

@pdurbin
Copy link
Member

pdurbin commented Oct 18, 2018

For anyone picking this up, please see #5164 for examples of the struggles people have when trying to make even simple changes to the tsv files. We might want to include a troubleshooting section.

@pdurbin pdurbin self-assigned this Oct 26, 2018
pdurbin added a commit that referenced this issue Oct 30, 2018
Also fix "catch all" field to be "_text_" and spacing of output.

Cross reference some code and docs.
@pdurbin pdurbin removed their assignment Oct 30, 2018
@pdurbin
Copy link
Member

pdurbin commented Oct 30, 2018

I mentioned at https://groups.google.com/d/msg/dataverse-community/9TNH41iGgG8/SZZaPbdvCwAJ that I was working on this issue and just created pull request #5251 and moved this to code review. Feedback is welcome!

@matthew-a-dunlap and I discussed how rather than documenting a fix we need for http://localhost:8080/api/admin/index/solr/schema to produce the right output ("_text_" instead of "text") that we should just fix it so I did. Everything else is docs and comments.

@sekmiller sekmiller self-assigned this Oct 31, 2018
@sekmiller
Copy link
Contributor

Looks good in general. Discussed some of the quirks with @pdurbin.

@pdurbin
Copy link
Member

pdurbin commented Oct 31, 2018

My to do list (will edit this comment for clarity in a bit):

@pdurbin
Copy link
Member

pdurbin commented Nov 1, 2018

Ok, as of d33b2aa I'm done hacking on this branch. I'm ready for more code review.

@pdurbin
Copy link
Member

pdurbin commented Nov 7, 2018

It would be easy to roll a fix for #3976 into the pull request if there's interest.

@pdurbin
Copy link
Member

pdurbin commented Nov 8, 2018

I addressed code review feedback in 2f5a1d6.

pdurbin added a commit that referenced this issue Nov 8, 2018
pdurbin added a commit that referenced this issue Nov 8, 2018
@kcondon kcondon self-assigned this Nov 8, 2018
@pdurbin
Copy link
Member

pdurbin commented Nov 13, 2018

I'd like to explain the two code changes in the pull request.

First, in d9adf2b I documented an API for learning more about metadata fields which has existed since 4.0 (undocumented) and adjusted the API to provide information about controlled vocabulary values.

The second change is basically a bug fix. In the "Updating the Solr Schema" section of the main doc in the pull request I explain the curl command for getting Solr fields out of Dataverse to put into schema.xml. For Solr 4 the "catchall" field was text but for Solr 7 it's now _text_ so now the curl command output the correct field name.

kcondon added a commit that referenced this issue Nov 13, 2018
add setup instructions for metadata blocks #5205
@kcondon kcondon closed this as completed Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants