Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arbitrary filetypes in index #5218

Closed
matthew-a-dunlap opened this issue Oct 19, 2018 · 2 comments
Closed

Support arbitrary filetypes in index #5218

matthew-a-dunlap opened this issue Oct 19, 2018 · 2 comments
Assignees
@kcondon
Milestone
4.10 - Additional...

Comments

@matthew-a-dunlap
Copy link
Contributor

matthew-a-dunlap commented Oct 19, 2018 •
edited

If Dataverse hits a filetype that is not in its known list (MimeTypeFacets), it throws an exception on indexing. This causes the filetype to not be indexed (the file itself still indexed).

There was already code in place to catch this exception when there was no match, but that exception was being caught by a different piece of code before it could be used to add a filetype.

I noticed this updating the index #5053. Note that in the fix I made sure that the exception is still being caught by the lower level code for all cases other than filetype indexing.
matthew-a-dunlap added a commit that referenced this issue Oct 19, 2018
@matthew-a-dunlap
Allow arbitrary filetypes to be indexed instead of error #5218
5060b3c
matthew-a-dunlap added a commit that referenced this issue Oct 19, 2018
@matthew-a-dunlap
minor clarification #5218
c301114
@matthew-a-dunlap matthew-a-dunlap mentioned this issue Oct 19, 2018
Merged
5 tasks
@matthew-a-dunlap
Copy link
Contributor Author

matthew-a-dunlap commented Oct 19, 2018 •
edited

Here is how my file results changed (268 files)

Previous:
screen shot 2018-10-19 at 3 38 01 pm

After fix:
screen shot 2018-10-19 at 3 42 04 pm

matthew-a-dunlap added a commit that referenced this issue Oct 19, 2018
@matthew-a-dunlap
Better method rename, less changes #5218
964b745
@pdurbin
Copy link
Member

pdurbin commented Oct 22, 2018

I just left a review on pull request #5219 with some discussion points.

matthew-a-dunlap added a commit that referenced this issue Oct 22, 2018
@matthew-a-dunlap
Reorg, method scope, javadoc #5218
71f3363
matthew-a-dunlap added a commit that referenced this issue Oct 22, 2018
@matthew-a-dunlap
Further simplification of mimetype methods #5218
8e04870
matthew-a-dunlap added a commit that referenced this issue Oct 22, 2018
@matthew-a-dunlap
MimeType Tests, cleanup, scope #5218
9fd7f45
@pdurbin pdurbin removed their assignment Oct 22, 2018
@kcondon kcondon self-assigned this Oct 23, 2018
@kcondon kcondon closed this as completed Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.10 - Additional Data Transfer Options
Development

No branches or pull requests
4 participants
@pdurbin @kcondon @djbrooke @matthew-a-dunlap