Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Conversion between Username/Email and "remote" accounts (Institution, ORCID, Google, and GitHub) no longer works #5260

Closed
pdurbin opened this issue Nov 1, 2018 · 3 comments
Closed

Regression: Conversion between Username/Email and "remote" accounts (Institution, ORCID, Google, and GitHub) no longer works #5260

pdurbin opened this issue Nov 1, 2018 · 3 comments
Assignees
@kcondon
Milestone
4.10 - Additional...

Comments

@pdurbin
Copy link
Member

pdurbin commented Nov 1, 2018

https://build.hmdc.harvard.edu:8443/job/phoenix.dataverse.org-apitest-develop/286/testReport/ indicates that conversion from "remote" to "builtin" accounts no longer works:

screen shot 2018-11-01 at 10 28 31 am

This was first observed as of b632e40 which is just a merge of a doc change so I suspect the previous merge of pull request #5244 caused the regression.
@pdurbin pdurbin changed the title Regression: migration to Username/Email accounts no longer works (from Institution, ORCID, Google, and GitHub) Regression: Conversion to Username/Email accounts no longer works (from Institution, ORCID, Google, and GitHub) Nov 1, 2018
@pdurbin pdurbin mentioned this issue Nov 1, 2018
Merged
5 tasks
This was referenced Nov 5, 2018
Merged
Closed
@pdurbin pdurbin self-assigned this Nov 13, 2018
@pdurbin pdurbin changed the title Regression: Conversion to Username/Email accounts no longer works (from Institution, ORCID, Google, and GitHub) Regression: Conversion between Username/Email and "remote" accounts (Institution, ORCID, Google, and GitHub) no longer works Nov 13, 2018
pdurbin added a commit that referenced this issue Nov 13, 2018
@pdurbin
auth creds are based on bundle key, not value #5260
ade04c4
@pdurbin pdurbin mentioned this issue Nov 13, 2018
Merged
@pdurbin
Copy link
Member Author

pdurbin commented Nov 13, 2018

As of dac897c (latest in develop branch, not release) here are the specific failures the API test suite is showing (all with the error "User doesn't know password"):

My fix for these is pull request #5306.

@pdurbin pdurbin removed their assignment Nov 13, 2018
@pameyer
Copy link
Contributor

pameyer commented Nov 14, 2018

ade04c4 successfully runs run-test-suite.sh in docker-aio (although setupIT broken recently-ish, and now requires a manual glassfish start). Will defer on reviewing code changes.

@djbrooke djbrooke assigned landreev and unassigned landreev Nov 14, 2018
@kcondon kcondon self-assigned this Nov 15, 2018
kcondon added a commit that referenced this issue Nov 16, 2018
@kcondon
Merge pull request #5306 from IQSS/5260-account-conversion
086e60c 
auth creds are based on bundle key, not value #5260
@kcondon kcondon closed this as completed Nov 16, 2018
@pdurbin
Copy link
Member Author

pdurbin commented Nov 16, 2018

Hooray! Now that pull request #5306 has been merged API tests are passing on phoenix again!

https://build.hmdc.harvard.edu:8443/job/phoenix.dataverse.org-apitest-develop/

screen shot 2018-11-16 at 12 32 09 pm

tcoupin pushed a commit to tcoupin/dataverse that referenced this issue Dec 4, 2018
@pdurbin @tcoupin
auth creds are based on bundle key, not value IQSS#5260
2dac445
@tcoupin tcoupin mentioned this issue Jan 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.10 - Additional Data Transfer Options
Development

No branches or pull requests
5 participants
@pdurbin @landreev @kcondon @djbrooke @pameyer