Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Admin API to change a username #5515

Closed
scolapasta opened this issue Feb 5, 2019 · 3 comments
Closed

Add Admin API to change a username #5515

scolapasta opened this issue Feb 5, 2019 · 3 comments
Assignees
@kcondon
Milestone
4.12

Comments

@scolapasta
Copy link
Contributor

We want to add an admin API that can be used to change an account's username. This would require dealing with the role assignment table and the actionlogrecord, but other connections (like creator id, etc) should be accounted for by foreign keys.
@pdurbin pdurbin mentioned this issue Feb 12, 2019
Closed
@pdurbin
Copy link
Member

pdurbin commented Feb 12, 2019

The specific SQL update statements can be found at #1445 (comment)

We will, of course, want all SQL updates to happen in a single transaction. I'm actually not sure how to accomplish this. I'm interesting in learning because I feel like there are occasions when only some SQL statements are run, leaving "bad data" in the database from partially completed actions. I assume it's some EJB magic?

@djbrooke djbrooke mentioned this issue Feb 15, 2019
Closed
@matthew-a-dunlap matthew-a-dunlap self-assigned this Feb 19, 2019
matthew-a-dunlap pushed a commit that referenced this issue Feb 20, 2019
Change userIdentifier mostly #5515
cfb7ff8 
The roleAssignments need to be changed.
matthew-a-dunlap pushed a commit that referenced this issue Feb 20, 2019
Set role assignments, better errors #5515
f96bef3
matthew-a-dunlap pushed a commit that referenced this issue Feb 21, 2019
Validate buitinUser before save transaction #5515
24fd317 
Without this submitting an invalid username (e.g. 'a') would cause a messy 500 error.
matthew-a-dunlap pushed a commit that referenced this issue Feb 21, 2019
Test changeAuthenticatedUserIdentifier #5515
9b901aa
@matthew-a-dunlap matthew-a-dunlap mentioned this issue Feb 21, 2019
Closed
5 tasks
matthew-a-dunlap pushed a commit that referenced this issue Feb 21, 2019
Document changeUserIdentifier #5515
41caaef
@matthew-a-dunlap matthew-a-dunlap removed their assignment Feb 21, 2019
matthew-a-dunlap pushed a commit that referenced this issue Feb 22, 2019
Remove stale comment #5515
2dbe107
matthew-a-dunlap pushed a commit that referenced this issue Feb 25, 2019
Fix formatting and add example #5515
9d5fd9f
@matthew-a-dunlap matthew-a-dunlap mentioned this issue Mar 12, 2019
Merged
5 tasks
matthew-a-dunlap added a commit that referenced this issue Mar 12, 2019
@matthew-a-dunlap
#5514 #5515 actionlogrecord for changeIdentifier
a8d2d34 
Also unify the two commands to both log the change message as the old user. This is somewhat required for changeIdentifier as there is no other user object to populate the log method, and its not worth creating a new path for this case.
@matthew-a-dunlap matthew-a-dunlap removed their assignment Mar 12, 2019
@matthew-a-dunlap
Copy link
Contributor

matthew-a-dunlap commented Mar 12, 2019 •
edited

The branch for this issue was combined with #5514 as they both needed the same changes to actionLogRecord. Please refer to the new PR for future review #5626

@matthew-a-dunlap matthew-a-dunlap mentioned this issue Mar 12, 2019
Closed
@scolapasta scolapasta self-assigned this Mar 13, 2019
@matthew-a-dunlap matthew-a-dunlap self-assigned this Mar 14, 2019
matthew-a-dunlap added a commit that referenced this issue Mar 14, 2019
@matthew-a-dunlap
#5514 #5515 create new users endpoint for non-admin user commands
7993eac 
Currently contains two superUser commands
@matthew-a-dunlap matthew-a-dunlap mentioned this issue Mar 14, 2019
Closed
matthew-a-dunlap added a commit that referenced this issue Mar 14, 2019
@matthew-a-dunlap
#5514 #5515 make commands superuser only
a7ff2c9
matthew-a-dunlap added a commit that referenced this issue Mar 14, 2019
@matthew-a-dunlap
#5514 #5515 new command cross-listing
91ab5bb
matthew-a-dunlap added a commit that referenced this issue Mar 14, 2019
@matthew-a-dunlap
#5514 #5515 more doc changes
ca9cffd
matthew-a-dunlap added a commit that referenced this issue Mar 14, 2019
@matthew-a-dunlap
#5514 #5515 actionLog as superuser, doc changes
381442b
@matthew-a-dunlap matthew-a-dunlap removed their assignment Mar 14, 2019
@kcondon kcondon self-assigned this Mar 18, 2019
@kcondon kcondon removed their assignment Mar 18, 2019
@kcondon
Copy link
Contributor

kcondon commented Mar 19, 2019

see #5514 for a list of issues for both merge and rename.

@kcondon kcondon self-assigned this Mar 19, 2019
@kcondon kcondon closed this as completed Mar 21, 2019
@djbrooke djbrooke mentioned this issue Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.12
Development

No branches or pull requests
7 participants
@pdurbin @landreev @sekmiller @scolapasta @kcondon @djbrooke @matthew-a-dunlap