Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Data popup message as a warning and not an error #5614

Closed
TaniaSchlatter opened this issue Mar 7, 2019 · 1 comment
Closed

Add Data popup message as a warning and not an error #5614

TaniaSchlatter opened this issue Mar 7, 2019 · 1 comment
Assignees
@kcondon
Milestone
4.12

Comments

@TaniaSchlatter
Copy link
Member

TaniaSchlatter commented Mar 7, 2019 •
edited

The message in the Add Data popup should not be displayed as an error, as it is informative and invites people to log in.

This:
Add_data_popup_muted_message

Or even better, this:
Add_data_popup_muted_message_buttons

Not this:
screen shot 2019-03-07 at 11 55 31 am
@sekmiller sekmiller self-assigned this Mar 26, 2019
@mheppler mheppler assigned mheppler and unassigned sekmiller Mar 26, 2019
mheppler added a commit that referenced this issue Mar 26, 2019
@mheppler
Revamped add data popup msg text and styles [ref #5614]
2103a29
@mheppler
Copy link
Contributor

Or...

Screen Shot 2019-03-26 at 2 12 41 PM

@mheppler mheppler mentioned this issue Mar 26, 2019
Merged
5 tasks
@mheppler mheppler removed their assignment Mar 26, 2019
@sekmiller sekmiller removed their assignment Mar 27, 2019
@kcondon kcondon self-assigned this Mar 27, 2019
kcondon added a commit that referenced this issue Mar 27, 2019
@kcondon
Merge pull request #5684 from IQSS/5614-add-data-popup-ui
3f59c86 
Revamped add data popup msg text and styles [ref #5614]
@kcondon kcondon closed this as completed Mar 27, 2019
@djbrooke djbrooke added this to the 4.12 milestone Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.12
Development

No branches or pull requests
5 participants
@mheppler @sekmiller @kcondon @djbrooke @TaniaSchlatter