Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new Unit Tests #5634

Closed
alexscheitlin opened this issue Mar 13, 2019 · 1 comment
Closed

Create new Unit Tests #5634

alexscheitlin opened this issue Mar 13, 2019 · 1 comment
Assignees
@kcondon
Milestone
4.12

Comments

@alexscheitlin
Copy link
Contributor

We, nikzaugg, rschlaefli and alexscheitlin, again focus on improving the testing (see #5619).

This time we will test a few methods that are not covered so far.
alexscheitlin added a commit to alexscheitlin/dataverse that referenced this issue Mar 13, 2019
@alexscheitlin
test Cart class IQSS#5634
a9314e9
alexscheitlin added a commit to alexscheitlin/dataverse that referenced this issue Mar 13, 2019
@alexscheitlin
test equality function of ActionLogRecord IQSS#5634
37b2d71
alexscheitlin added a commit to alexscheitlin/dataverse that referenced this issue Mar 13, 2019
@alexscheitlin
test SortBy class IQSS#5634
e622831
@alexscheitlin alexscheitlin mentioned this issue Mar 13, 2019
Merged
5 tasks
@nikzaugg nikzaugg mentioned this issue Mar 14, 2019
Merged
5 tasks
@djbrooke
Copy link
Contributor

@nikzaugg - @matthew-a-dunlap added one requested change in the PR. I moved this back to the Community Dev column on https://waffle.io/IQSS/dataverse. Let us know when it's ready for another code review pass! Thank you!

rschlaefli added a commit to rschlaefli/dataverse that referenced this issue Mar 16, 2019
@rschlaefli
Add test cases for FileSizeChecker.isAllowedFileSize IQSS#5634
8b3fbbf
rschlaefli added a commit to rschlaefli/dataverse that referenced this issue Mar 16, 2019
@rschlaefli
Add tests for DataAccess.createNewStorageIO IQSS#5634
0a374c7
rschlaefli added a commit to rschlaefli/dataverse that referenced this issue Mar 16, 2019
@rschlaefli
Add unit tests for FileMetadata.getFileDateToDisplay IQSS#5634
4031997
@rschlaefli rschlaefli mentioned this issue Mar 16, 2019
Merged
5 tasks
@kcondon kcondon self-assigned this Mar 18, 2019
@kcondon kcondon closed this as completed Mar 18, 2019
@djbrooke djbrooke added this to the 4.12 milestone Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.12
Development

No branches or pull requests
5 participants
@pdurbin @kcondon @djbrooke @matthew-a-dunlap @alexscheitlin