Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Groups UI: Pressing Enter in empty input field deletes group without warning #5677

Closed
aseeland opened this issue Mar 22, 2019 · 2 comments
Closed

Groups UI: Pressing Enter in empty input field deletes group without warning #5677

aseeland opened this issue Mar 22, 2019 · 2 comments
Assignees
@kcondon
Milestone
4.12

Comments

@aseeland
Copy link

On the "manage-groups"-page we experienced the following problem: When editing an existing group, placing the cursor in the input field for Group Members, and then (accidentally) pressing "Enter", the whole group is deleted without warning dialog :-(

The same happens in the "create new group"-dialog.

We have Dataverse Version 4.9.4, but I could reproduce the problem on demo.dataverse.org which runs Version 4.11
@pdurbin
Copy link
Member

pdurbin commented Mar 22, 2019

😞

@djbrooke djbrooke assigned djbrooke and unassigned djbrooke Mar 27, 2019
@sekmiller sekmiller self-assigned this Mar 27, 2019
sekmiller added a commit that referenced this issue Mar 28, 2019
@sekmiller
#5677 don't render delete group popup when not in use
47e5fce
@sekmiller
Copy link
Contributor

The "enter key" v. "save button" was not a red herring. Somehow, the enter key was invoking the "Continue" button on the Delete Confirmation popup. Previously this popup is rendered, but not visible until you press the trash can button. I added code that leaves the popup unrendered until you press the trash can button. That fixes the only issue I was able to recreate, that is in Firefox when you press "enter" with the cursor in the autocomplete role assignee control the group is deleted.

@sekmiller sekmiller mentioned this issue Mar 28, 2019
Merged
5 tasks
@sekmiller sekmiller removed their assignment Mar 28, 2019
@kcondon kcondon self-assigned this Mar 28, 2019
@kcondon kcondon closed this as completed Mar 28, 2019
@pdurbin pdurbin added this to the 4.12 milestone Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.12
Development

No branches or pull requests
5 participants
@pdurbin @sekmiller @kcondon @aseeland @djbrooke