Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installers broken, because of the new pom file structure. #8494

Closed
j-n-c opened this issue Mar 16, 2022 · 3 comments · Fixed by #8495
Closed

Installers broken, because of the new pom file structure. #8494

j-n-c opened this issue Mar 16, 2022 · 3 comments · Fixed by #8495
Milestone
5.10

Comments

@j-n-c
Copy link
Contributor

j-n-c commented Mar 16, 2022

What steps does it take to reproduce the issue?

  • When does this issue occur?
    When trying to deploy dataverse using vagrant

  • Which page(s) does it occurs on?
    N/A

  • What happens?
    Running vagrant up starts the deployment process, but after configuring Solr the process fails because the python installer is unable to find a .war file:

==> default: Running provisioner: shell...
    default: Running: /tmp/vagrant-shell20220316-16786-1agei0k.sh
    default: enabling non-interactive mode
    default: 
    default: This appears to be a RedHat system; good.
    default: Checking for required components...
    default: Sorry, I can't seem to find an appropriate warfile.
    default: Are you running the installer from the right directory?

  • To whom does it occur (all users, curators, superusers)?

  • What did you expect to happen?
    Deployment using vagrant up should be successful

Which version of Dataverse are you using?
5.9

Any related open or closed issues to this bug report?
Not that I could find

Screenshots:

No matter the issue, screenshots are always welcome.

To add a screenshot, please use one of the following formats and/or methods described here:
@j-n-c
Copy link
Contributor Author

j-n-c commented Mar 16, 2022

What seems to happening is that the the python installer is not able retrieve the dataverse version from the project POM. Instead it retrieves the placeholder ${revision}, which will make the installer search for file ../../target/dataverse-${revision}.war, which does not exist.

I have successfully been able to deploy dataverse using vagrant, but using the revision field from the POM in modules/dataverse-parent. Does this fileld contain the dataverse release version?

If it does, the installer can be fixed using the lines below and I'd be more than happy to submit a PR:

tree = ET.ElementTree(file='../../modules/dataverse-parent/pom.xml')
for elem in tree.iter("*"):
    if elem.tag == '{http://maven.apache.org/POM/4.0.0}revision':
        warfileVersion = elem.text

j-n-c pushed a commit to j-n-c/dataverse that referenced this issue Mar 16, 2022
Fixed python installer dataverse version parsing to fix IQSS#8494
1104f23
@j-n-c j-n-c mentioned this issue Mar 16, 2022
Merged
@pdurbin
Copy link
Member

pdurbin commented Mar 16, 2022

docker-aio is also affected. I'm getting this error on develop:

/opt/dv/testdata/scripts/installer
Payara setup complete
Wed Mar 16 15:05:40 UTC 2022
remote failure: File not found : /opt/dv/dvinstall/dataverse.war
Command deploy failed.

I'll update the title of this issue to reflect this.

@pdurbin pdurbin changed the title Vagrant Deployment not working: 'can't seem to find an appropriate warfile.' Vagrant and docker-aio deployment failure: "can't seem to find an appropriate warfile", "file not found" Mar 16, 2022
@pdurbin pdurbin added this to the 5.10 milestone Mar 16, 2022
@landreev
Copy link
Contributor

Thank you for catching this!
I feel bad for missing this, because I had spent some time looking at the PR that changed the pom files; I just somehow got it reversed, where the parent, and the project pom files were ending up, when thinking about it in the context of the installer.

@landreev landreev changed the title Vagrant and docker-aio deployment failure: "can't seem to find an appropriate warfile", "file not found" Installer broken, because of the new pom file structure. Mar 16, 2022
landreev added a commit to j-n-c/dataverse that referenced this issue Mar 16, 2022
@landreev
Fixing the Makefile
bf30a31 
to reflect the new pom file structure (IQSS#8494)
landreev added a commit to j-n-c/dataverse that referenced this issue Mar 16, 2022
@landreev
Fixes the old (perl) installer
b6bd09c 
To reflect the new pom file structure. (IQSS#8494)
@landreev landreev changed the title Installer broken, because of the new pom file structure. Installers broken, because of the new pom file structure. Mar 16, 2022
kcondon added a commit that referenced this issue Mar 16, 2022
@kcondon
Merge pull request #8495 from j-n-c/8494-vagrant-war-search-fix
3c616d2 
Installer fixes, reflecting the new pom file structure #8494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.10
Development

Successfully merging a pull request may close this issue.

Installer fixes, reflecting the new pom file structure #8494 j-n-c/dataverse
3 participants
@pdurbin @landreev @j-n-c