Overview

The Ghost drafts problem for 5.11 needs a post-mortem. The purpose will be to discuss pitfalls in the current code and how we can refactor the code to prevent similar incidents. Suggestions have included renaming methods and refactoring commands.

Objective:
Get the right people on the team together around a document and think through what happened and how it might be addressed through some combination of: refactoring code, updating documentation, updating code examples.

There is a document: 5.11 ghost drafts postmortem discussion. If it helps, it can be used to structure and or document the discussion.

Definition of done:

• Internal discussion as a team lead by whoever owns this issue.
• can we lower the odds of another developer encountering this issue through a code change or process change?
• As a team, do we want to make the change(s)
• If the team decides to make the changes, create the issue(s) that would do the job and submit the issue(s) for prioritization

Context
For example:

• The getEditVersion method creates a new dataset draft, which is appropriate in the case where the user actively wants to create a new dataset draft. However here it created ghost draft. It's a ghost draft because the developer
  

Associated Bugs

In release 5.11 there were serious data integrity and data security bugs that were fixed in 5.12.

• Internal Server Error on dataset page after deleting files, Vanishing files from already published versions. #8867
• Version table always shows DRAFT? #8845
• broken kebab on file listing page when dataset out of compliance with new (5.11) terms policy #8742

Impacted Customers:

• Fix the files affected by the 5.11 delete bug in production