Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent error from the new Harvesting Clients test #9240

Closed
landreev opened this issue Dec 20, 2022 · 7 comments · Fixed by #9520
Closed

Intermittent error from the new Harvesting Clients test #9240

landreev opened this issue Dec 20, 2022 · 7 comments · Fixed by #9520
Assignees
@landreev
Labels
NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... pm.GREI-d-1.4.1 NIH, yr1, aim4, task1: Resolve OAI-PMH harvesting issues Size: 10 A percentage of a sprint. 7 hours.
Milestone
5.14

Comments

@landreev
Copy link
Contributor

Has been observed a couple of times on Jenkins since the PR #9227 was merged. Meaning, it's intermittent, the test passes on most runs.
The error happens in the new test that's somewhat extensive and runs a real harvest of an external archive. However, the 500 below happens before anything heavy is attempted, merely when creating the new harvesting client:

java.lang.AssertionError: expected:201 but was:500
at edu.harvard.iq.dataverse.api.HarvestingClientsIT.testHarvestingClientRun(HarvestingClients0T.java:184)

which is really a cheapest operation you can think of. This makes me think that this is another weird timing condition caused by an overall load of a full restassured run on the system. I expect it to be straightforward to fix/work around.
@pdurbin
Copy link
Member

pdurbin commented Jan 5, 2023

@landreev thanks for opening this issue. Another failure just occurred (same line and 500 as above):

@scolapasta scolapasta added this to This Sprint 🏃‍♀️ 🏃 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) via automation Jan 25, 2023
@kcondon
Copy link
Contributor

kcondon commented Jan 25, 2023

Happens with Sonarcube Fixes #9320, too. Not sure if keeping track of failures is helpful here?

@scolapasta scolapasta added the Size: 3 A percentage of a sprint. 2.1 hours. label Jan 25, 2023
@scolapasta scolapasta added this to the 5.13 milestone Jan 25, 2023
@scolapasta scolapasta added Size: 10 A percentage of a sprint. 7 hours. and removed Size: 3 A percentage of a sprint. 2.1 hours. labels Jan 25, 2023
@scolapasta scolapasta removed this from the 5.13 milestone Jan 25, 2023
@mreekie mreekie added this to New in deleteMeAfterTesting via automation Feb 22, 2023
@mreekie mreekie removed this from New in deleteMeAfterTesting Feb 23, 2023
@mreekie mreekie added this to New in deleteMeAfterTesting via automation Feb 23, 2023
@mreekie mreekie removed this from New in deleteMeAfterTesting Feb 23, 2023
@mreekie mreekie added this to New in deleteMeAfterTesting via automation Feb 23, 2023
@mreekie mreekie removed this from New in deleteMeAfterTesting Feb 23, 2023
@mreekie mreekie added this to New in deleteMeAfterTesting via automation Feb 23, 2023
@mreekie mreekie removed this from New in deleteMeAfterTesting Feb 23, 2023
@mreekie mreekie added the NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... label Mar 1, 2023
@mreekie mreekie added the pm.GREI-d-1.4.1 NIH, yr1, aim4, task1: Resolve OAI-PMH harvesting issues label Mar 20, 2023
@pdurbin
Copy link
Member

pdurbin commented Mar 24, 2023

Another one: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9290/10/testReport/edu.harvard.iq.dataverse.api/HarvestingClientsIT/testCreateEditDeleteClient/

@pdurbin pdurbin mentioned this issue Mar 24, 2023
Merged
3 tasks
@pdurbin pdurbin moved this from ▶ SPRINT READY to This Sprint 🏃‍♀️ 🏃 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Mar 29, 2023
@pdurbin pdurbin moved this from This Sprint 🏃‍♀️ 🏃 to ▶ SPRINT READY in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Mar 29, 2023
@landreev landreev moved this from ▶ SPRINT READY to This Sprint 🏃‍♀️ 🏃 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Mar 29, 2023
@landreev
Copy link
Contributor Author

I pulled it into this sprint yesterday, I'm definitely willing to spend a couple of hours resolving this. But I am also determined to keep the amount of effort under the assigned "10". If it turns out non-trivial at all to be able to truly figure out what's going on, I'm going to just throw seconds of sleep at it until it passes reliably.

@pdurbin
Copy link
Member

pdurbin commented Apr 11, 2023

We had a related failure on develop yesterday: https://jenkins.dataverse.org/job/IQSS-dataverse-develop/1306/consoleFull

"[ERROR] Failures: ", "[ERROR] HarvestingClientsIT.testCreateEditDeleteClient:109 expected:<201> but was:<500>",

For the line number, develop is e12f3e6

@landreev landreev moved this from This Sprint 🏃‍♀️ 🏃 to IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Apr 12, 2023
@landreev landreev self-assigned this Apr 12, 2023
@landreev
Copy link
Contributor Author

Just grabbed this issue, going to throw some copious amounts of sleep at it.

landreev added a commit that referenced this issue Apr 12, 2023
@landreev
quick sleeps added. #9240
3ec97df
@landreev
Copy link
Contributor Author

Ouch. It has nothing to do with timing. And everything to do with the laws of probability.

landreev added a commit that referenced this issue Apr 12, 2023
@landreev
the real fix. #9240
a5c6aca
@landreev landreev mentioned this issue Apr 12, 2023
Merged
kcondon added a commit that referenced this issue Apr 13, 2023
@kcondon
Merge pull request #9520 from IQSS/9240-harvest-test-failure
072213b 
intermittent harvest tests failures #9240
@pdurbin pdurbin added this to the 5.14 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@landreev landreev

Labels
NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... pm.GREI-d-1.4.1 NIH, yr1, aim4, task1: Resolve OAI-PMH harvesting issues Size: 10 A percentage of a sprint. 7 hours.
Projects
IQSS Dataverse Project
Status: No status
Milestone
5.14
Development

Successfully merging a pull request may close this issue.

intermittent harvest tests failures #9240 IQSS/dataverse
5 participants
@pdurbin @landreev @scolapasta @kcondon @mreekie