Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network: Add tab with information to easily get addnode information for Wallets #321

Merged
merged 3 commits into from Dec 24, 2019
Merged

Network: Add tab with information to easily get addnode information for Wallets #321

merged 3 commits into from Dec 24, 2019

Conversation

TheHolyRoger
Copy link
Collaborator

As requested.

Network: Add tab with information to easily get addnode information for Wallets.

@TheHolyRoger TheHolyRoger mentioned this pull request Dec 22, 2019
Closed
@TheHolyRoger TheHolyRoger self-assigned this Dec 22, 2019
@TheHolyRoger
Copy link
Collaborator Author

@Altcoin-Cash @lyricidal @minkcrypto @cryptozeny

If any of you get a chance to test this PR it would be appreciated! Not massive changes so want to merge this to master soon.

@cryptozeny
Copy link

could you attach the screenshot? 😉

@TheHolyRoger
Copy link
Collaborator Author

net

@cryptozeny
Copy link

it seems kooooool

@TheHolyRoger
Copy link
Collaborator Author

@altmarkets

@uaktags
Copy link
Collaborator

uaktags commented Dec 23, 2019

Vulcano is currently downloading the blockchain (1y 18wk behind) and will then spin up a test of this for ya. Don't see any reason why this would not work though. 👍

@TheHolyRoger
Copy link
Collaborator Author

Nice cheers @uaktags ! Are you on discord or anything?

@altmarkets
Copy link

Works great thanks @TheHolyRoger
http://altmco.in/network

@TheHolyRoger
Copy link
Collaborator Author

To do: add setting to hide port info

@uaktags
Copy link
Collaborator

uaktags commented Dec 23, 2019

Nice cheers @uaktags ! Are you on discord or anything?

@TheHolyRoger yea, i'm on discord Tags#5633

@uaktags
Copy link
Collaborator

uaktags commented Dec 24, 2019

Working good, tested with Vulcano and XPChain (neither coin I use anymore, just daemons that I've used in the past)
I'm thinking a cool thing to add would be a copy to clipboard and/or a download file.
Otherwise, this looks good to merge

@uaktags uaktags self-requested a review December 24, 2019 19:14
@uaktags uaktags merged commit 7f3c7d0 into iquidus:master Dec 24, 2019
@TheHolyRoger TheHolyRoger deleted the dev-addpeerinfotab branch December 25, 2019 21:00
willli666 pushed a commit to atlantiscoin/explorer that referenced this pull request Jan 1, 2020
@uaktags
Merge pull request iquidus#321 from TheHolyRogerCoin/dev-addpeerinfotab
e52e1b1 
Network: Add tab with information to easily get addnode information for Wallets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uaktags uaktags uaktags approved these changes

Assignees

@TheHolyRoger TheHolyRoger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TheHolyRoger @cryptozeny @uaktags @altmarkets