Extend (E)CL testing #368
Merged
Extend (E)CL testing #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olebole
changed the title
Originally, CL used FORTRANs NINT function which always rounds up for .5, while nearbyint rounds towards the even number in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is triggered by #367 (noirlab-iraf/gemini#10) in that it is worth to have a test of more CL and ECL functionality as well, and to test both packages. This implies separating the CL tests, and also separating the tests for ECL extended functionality into separate files cl.md and ecl.md.
The added tests are taken from pyraf/tests/test_cli.py.
This way, we found a minor glitch with the nint CL intrinsic:
nint(2.5)should return 3 (half should round upwards), while the C function nearbyint() returned 2 (half rounds towards even). This is now fixed by using the C function roundl() instead.