Remove outdated options from XC #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olebole
force-pushed
the
no-m32
branch
2 times, most recently
from
a2d9347
to
fb2e086
Compare
This feature was anyway incompatible to shared libs on Linux and macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major driver here is the removal of the arch dependent
-m32flag (for i386). This flag shadowed a missing linker flag in the Makefile; this should help us moving towards cross compileability.Then, all "shared image" support was removed. This was modelled for the SunOS shared library model, which involved patching a shared image. On Linux and macOS, shared library support works completely different, so it is removed here. I we ever want to enable a libiraf.so shared library, we will anyway re-implement this (maybe based on the Digital Unix version which is closer to what is used today).
Finally, a few variables and options were removed that are no longer in use. For compatibility, they stay as no-op in the argument list.