Use update_idletasks() to avoid hangs on epar GUI window.
#145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently using `update()` for tkinter objects hang the process when `epar` is executed in pyraf. Using `update_idletasks()` appears to fix it. This is a possible fix for iraf-community#144
olebole
requested changes
Oct 19, 2022
I removed `# isort skip` comments pointed out in the review.
|
I edited it directly on GitHub. Hope it works (I'm not get used to the github workflow). |
|
Great, thanks! Please give me a few days to check (I am quite busy at the moment...) |
|
I can confirm that this works on Linux (Debian testing) as well. So, I will merge. Thank you very much for this finding and the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently using
update()for tkinter objects hang the process wheneparis executed in pyraf. Usingupdate_idletasks()appears to fix it.This is a possible fix for #144
I added
# isort: skipto avoid auto-formatting with my editor (I couldn't disable it, sorry). Please ignore these changes.