Fix the deprecation error for resize_event
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure some backward compatibility needs to be implemented. |
|
Thank you very much for the bug report and the PR! From a quick search on the Matplotlib documentation I get the impression that the From this, I would not see the need for further backward compatibility, but may someone test with a relevant Matplotlib version? |
|
@monodera I updated the main branch to fix the readthedocs (and other CI) errors. Could you rebase your branch to the updated main? |
olebole
changed the title
resize_event (#157).resize_event
…unity#157). `resize_event` has been deprecated since matplotlib 3.6. This commmit transitions from `resize_event` to `ResizeEvent` as recommended. Ref: https://qiskit.org/ecosystem/metal/_modules/matplotlib/backend_bases.html
monodera
force-pushed
the
u/monodera/resize_event
branch
from
26ece83
to
8ac6f7a
Compare
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resize_eventhas been deprecated since matplotlib 3.6. This commmit transitions fromresize_eventtoResizeEventas recommended.Ref: https://qiskit.org/ecosystem/metal/_modules/matplotlib/backend_bases.html
Fixes: #157