Use Cocoa API for window activation/deactivation handling #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olebole
force-pushed
the
cocoa
branch
2 times, most recently
from
8305da9
to
f481500
Compare
|
I didn't get feedback from @mjfitzpatrick here, so I am no sure whether this is resolved for ARM64. However, since it works for Intel, I would guess the same for Mac, thus merging. Please file a new issue if there are still problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just replaces GetCurrentProcess(), GetFrontProcess(), SetFrontProcess() and CPSSetProcessName() with their Cocoa counterparts.
The undocumented function CPSEnableForegroundOperation() is removed as it seems that it is no longer needed.
Tested on an Intel Mac, Catalina 10.15.7 and Sonoma 14.4. @mjfitzpatrick could you test this on a Sonoma ARM Mac (
pip3 install git+https://github.com/iraf-community/pyraf@cocoa)?Fixes #163