[EXP] Enable CI #45
Merged
[EXP] Enable CI #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhunkeler
reviewed
Mar 8, 2018
Jenkinsfile
Outdated
| PIP_INST = "pip install" | ||
| CONDA_INST = "conda install -y -q" | ||
| PY_SETUP = "python setup.py" | ||
| PYTEST_ARGS = "--basetemp=tests_output --junitxml results.xml" |
There was a problem hiding this comment.
How do you feel about adding --capture=sys or --capture=fd to PYTEST_ARGS? I'm noticing that IRAF tasks are inconsistently verbose, and PyRAF doesn't always redirect stdout and stderr streams correctly when instructed to.
There was a problem hiding this comment.
@jhunkeler , wait a minute. Now I remember that I already have addopts = --capture=no in setup.cfg. Is that not sufficient? Won't Jenkins be smart enough to pick up pytest options from there?
pllim
commented
Mar 8, 2018
lib/pyraf/tests/utils.py
Outdated
| @@ -4,8 +4,11 @@ | |||
| from astropy.utils.data import get_pkg_data_contents | |||
|
|
|||
| IS_PY2 = sys.version_info < (3, 0) | |||
| DATA_DIR = os.path.join(os.path.dirname(__file__), 'data') | |||
There was a problem hiding this comment.
Why is this necessary? Can't you just use get_pkg_data_filename from astropy.utils.data? See L4.
pllim
commented
Mar 9, 2018
tests/test_core_nongraphics.py
Outdated
|
|
||
| @pytest.mark.skipif(not HAS_IRAF, reason='Need IRAF to run') | ||
| def test_subproc(): | ||
| pass |
There was a problem hiding this comment.
Note: This is just a placeholder right now. I didn't get around to it yet.
Cannot add conda channel on Travis
Run real tests on Jenkins [skip travis]
Add graphics test. Need six now. Move gen stuff to utils. [skip travis]
Clean up matrix Fix invalid redirection
…now. Attempt to fix failures. Add badge. Fix which test. Fix manifest
Add pset_msstat data Initial commit of test_pset_msstat.py Define common data directory Cleanup Move tests up to top-level Include tests in sdist Fix permissions Add module comment Initial commit of test_core_nongraphics.py Initial commit of core_irafparlist_output.ref Initial commit of conftest.py Fix line endings Remove PYRAF_ environment variables Check for login.cl Port remainder of msstat2egstp.py into test_pset_msstat.py Initial commit of test_dqbits.py (originally test_207.py) Let pytest do its thing Rename test_pset_msstat.py -> test_using_tasks.py; Consolidate test_dqbits.py into it Redirect streams Cleanup and consolidation PEP8 changes Initial commit of test_invocation.py Add HAS_PYRAF_EXEC, remove SCRIPTS_DIR, silence iraf.imhead Ignore generated cmd_* files. Fix invalid import of StringIO Add python3 compat, even though adding it makes no sense given the context here. Test in develop mode ipython is a dependency Remove global print statement install_requires here or there, not but both places Require ipython, because it is a command-line option Import spacing Test various invocations Add missing skipif(s) Import spacing Pyraf develop mode is broken. Just install. Re-order assertion Due to hybrid testing style, we still need local extensions Normalize test name Consolidate cases, fix subprocess stdin usage, redirect stderr correctly Add no command wrapper tests Inherit from object Strip subprocess test Add subproc tests Partial irafparlist implementation Finish irafparlist implementation Add skipif decorators Delete reference file Add some gki system tests Remove gki system tests Add gki psikern suite, and mark as xfail Update Jenkinsfile
Purge inline test
Move old tests to old_files. Find and port hidden tests in modules.
|
Hey, hey, it's green. Merging. |
This was referenced Mar 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better or worse...
Fix #42
Fix #44
Use Jenkins with proper IRAF installation?
Make sure they are not skipped. Need Joe's Docker magic.
Add tests from Ole
Move "embedded" tests in
lib/pyraf/*.pymodules totestsproperly? After talking to Chris S., need to keep duplicate of these and deleted modules in a new dirlib/pyraf/old_filesso he can run them his way.Port over from pandokia (strike-through means those tests are now redundant and thus not ported over):
pyraf/invoke_redo/invoke.test_get_status_and_output_ofpyraf/invoke_redo/invoke.test_has_latest_testcodepyraf/invoke_redo/invoke.test_nows_get_status_and_output_ofpyraf/invoke_redo/invoke.test_usageFollow up after merging this:
xfailported tests (grepfor "BUG" and "TODO"). See TST: Revisit skipped and xfailed tests #48