Update TelegramClient.php #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes I made to the code include: Changing the method signature of prepareRequest method to have a return type of array. Replacing isset with $this->baseBotUrl ?? static::BASE_BOT_URL in the getBaseBotUrl method to check if $this->baseBotUrl is set and if it's not set, return static::BASE_BOT_URL. Using type hints in method signatures to indicate the expected types of arguments and return values. Using PHP 7.4 syntax for attribute property types and null coalescing operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes I made to the code include:
Changing the method signature of prepareRequest method to have a return type of array.
Replacing isset with $this->baseBotUrl ?? static::BASE_BOT_URL in the getBaseBotUrl method to check if $this->baseBotUrl is set and if it's not set, return static::BASE_BOT_URL.
Using type hints in method signatures to indicate the expected types of arguments and return values.
Using PHP 7.4 syntax for attribute property types and null coalescing operator.