Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy to GuzzleHttpClient #721

Merged
merged 2 commits into from Mar 13, 2020
Merged

Add proxy to GuzzleHttpClient #721

merged 2 commits into from Mar 13, 2020

Conversation

vokamut
Copy link
Contributor

@vokamut vokamut commented Mar 12, 2020

No description provided.

irazasyed
irazasyed reviewed Mar 12, 2020
View reviewed changes
src/HttpClients/GuzzleHttpClient.php Outdated
@@ -109,6 +109,7 @@ private function getOptions(
array $headers,
$body,
$options,
$proxy = null,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$proxy should go at the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@irazasyed irazasyed merged commit 5bacf81 into irazasyed:develop Mar 13, 2020
@irazasyed
Copy link
Owner

Thanks!

@vokamut vokamut deleted the patch-1 branch March 13, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irazasyed irazasyed irazasyed left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vokamut @irazasyed