Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package to work on PHP 7.3 (do not use PHP 7.4 syntax) #969

Merged
merged 4 commits into from
Jul 8, 2022
Merged

Fix package to work on PHP 7.3 (do not use PHP 7.4 syntax) #969

merged 4 commits into from
Jul 8, 2022

Conversation

alies-dev
Copy link
Contributor

@alies-dev alies-dev commented Jul 8, 2022 •
edited
Loading

It's fixed by 34071a1

Additionally, I've added few more checks on CI:

New GitHub workflow steps are fast, no need to extract them into a parallel job as PHP preparation with composer install slower than these steps

@irazasyed irazasyed merged commit aab668b into irazasyed:develop Jul 8, 2022
@irazasyed
Copy link
Owner

Thanks 😊

@alies-dev
Copy link
Contributor Author

@irazasyed
you are too fast, I'm too lazy -- I haven't setup PHP v7.3 locally, there are probably more issues caused PHP 7.4 syntax, I'm fixing them based on CI output, but If I'll get one more -- I'll setup php 7.3 locally :)

@alies-dev
Copy link
Contributor Author

@irazasyed
Hey superhero! New PR is ready, all green this time! 🚀
#970

@irazasyed
Copy link
Owner

Merged. Thank you so much 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alies-dev @irazasyed