Upgrade to 0.42, fix wpt checkout, add channelCount to MediaTrackConstraints #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orottier
force-pushed
the
feature/channel-count-media
branch
from
6e47300
to
0f1553c
Compare
|
I believe #56 broke our CI and should be reverted separately on the main branch |
```
error[E0308]: mismatched types
--> src/audio_buffer.rs:217:17
|
216 | .create_arraybuffer_with_borrowed_data(
| ------------------------------------- arguments to this method are incorrect
217 | data_ptr,
| ^^^^^^^^ types differ in mutability
|
= note: expected raw pointer `*mut u8`
found raw pointer `*const u8`
note: method defined here
--> /Users/otto/.cargo/registry/src/index.crates.io-6f17d22bba15001f/napi-2.15.1/src/env.rs:508:17
|
508 | pub unsafe fn create_arraybuffer_with_borrowed_data<Hint, Finalize>(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
orottier
force-pushed
the
feature/channel-count-media
branch
from
0f1553c
to
1fd1e22
Compare
|
Ready for merging! |
12 tasks
|
Cool thanks! Will try to set up some example with Pure Data or Max patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trevorparscal could you have a look if this works for you? I don't have a multichannel mic at hand here and the underlying
cpallibrary is surprisingly relaxed in allowing exotic channel counts - so I can't really test properly myself.Fixes #74