Specify channel key validation (MODE +k). #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progval
added a commit
to progval/unrealircd
that referenced
this pull request
Aug 10, 2021
This is more user-friendly (prevents setting a different key than what the other requested) and makes the behavior consistent with InspIRCd and Ergo (and hopefully others soon). ircdocs/modern-irc#111
This was referenced Aug 10, 2021
progval
added a commit
to progval/solanum
that referenced
this pull request
Aug 10, 2021
…rs or truncating This is more user-friendly (prevents setting a different key than what the other requested) and makes the behavior consistent with InspIRCd and Ergo (and hopefully others soon). ircdocs/modern-irc#111
DanielOaks
reviewed
Aug 16, 2021
Tested with Insp, Unreal, Ergo, Hybrid/Chary/Solanum, and ircu2; using a passphrase with a space (which is forbidden by RFC2812). They all either let it through, or return one of the two numerics.
To make sure readers don't confuse them.
* ERR_INVALIDKEY: ircu * ERR_INVALIDMODEPARAM: insp, ergo * truncating: irc2, unreal * stripping: hybrid family (including solanum * silently dropping: bahamut
progval
force-pushed
the
channel-key-validation
branch
from
d564103
to
03faa99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with Insp, Unreal, Ergo, Hybrid/Chary/Solanum, and ircu2;
using a passphrase with a space (which is forbidden by RFC2812),
very long passphrases, and empty passphrase.
They all either let it through, or return one of the two numerics.
(reopened from GH-107 because I accidentally merged it)