-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommend that server names contain a dot #148
Conversation
I don't think a particular numeric is the right place to document something as central as this. What about a new section early in the document, to define identifiers? You could merge in this paragraph from https://modern.ircdocs.horse/#client-to-server-protocol-structure :
And also reference it from https://modern.ircdocs.horse/#source |
It doesn't seem like there's consensus, @jwheare said on IRC they're not a fan of this. |
Can't think of any public network that doesn't use a dot in their servername. It is helpful for software to distinguish server from user and likely expected in certain cases. The thing is, the servername is a variable in a config file of the server software for end users to control. Unless there's a comment in that config to explain the usage of a dot, they won't be aware of it (end users don't read ircdocs). That said, i'm not opposed to this PR. |
When configured with a server name without a dot:
and I couldn't test irc2, ircu2, and bahamut for unrelated reasons; but they are each deployed on a single network these days, so it doesn't really matter. According to ircstats, this covers at least 75% of all servers, which seems good enough for me. |
I’m not opposed to recommending servers do this, especially given current IRCd behaviour. But I don’t think it fully solves the issue of disambiguating servers from nicknames because of instances in the wild that I’ve seen servers allow dots in nicks (even if that’s invalid). I don’t think presence of a dot is a safe or robust heuristic to always rely on and the way it’s stated here encourages people that it is. |
ugh, I didn't think of that. Do these servers with dotted nicks always send a full NUH? |
They should do, but might not always, e.g. if znc is sitting in front of them. I think regardless of where and how this occurs in practice, we shouldn't be encouraging clients to rely on this. I'd prefer encouraging an approach that doesn't label the source one way or the other. You can determine how you treat the source at the point of use. e.g. for commands like JOIN, NICK etc, it's always going to be a nick so you can always treat it as such. |
There are edge cases where this approach doesn't work too well, e.g. PRIVMSG/NOTICE. These can come from a server or a user, and there's no good way to make the difference. |
Can you describe a situation where that matters much though? If, for instance, you have a client that does things like exposing certain actions on clicking a nickname when displayed alongside their message, like PMing/whoising them or whatever, then you can do one or either of:
This might result in not offering those actions for a non-nuh nick in a private message, but given this an edge case that's probably acceptable. It's not like users won't be able to perform those actions in other ways (slash commands etc) |
Here's an example:
Not really an option, the full NUH is optional for user messages, and some servers can omit it, especially when sending chathistory.
My mobile client doesn't have slash-commands, and I don't want to force users to know about slash-commands to be able to use IRC. |
I'm just going to leave it at my earlier comment "I’m not opposed to recommending servers do this". This PR is fine. |
Hm, I'm not sure. There are already sections named "channel", "server" and "client". The one about channels describes the allowed characters. The one about clients says: "See the protocol grammar rules for what may and may not be used in a nickname" (but the document never actually defines the nickname in the grammar, see #157). So maybe it would make sense to describe the server/client name rules inside these existing sections? |
Moved to the "server" section, let me know what you think. |
Gentle ping, what do you think of this version @progval? |
No description provided.