Specify WHOWAS #170
Merged
Specify WHOWAS #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syntax and base description are copied from https://datatracker.ietf.org/doc/html/rfc1459#section-4.5.3 with two changes: 1. removed `<server>` because it is pointless 2. "`<count>` SHOULD be a non-positive number" because one implementation (ircu2) does not handle `0` the same way others do. (besides, there is no reason for clients to send that) I ignored https://datatracker.ietf.org/doc/html/rfc2812#section-3.6.3 because noone seems to implement wildcards, and the only implementation supporting TARGMAX WHOWAS (Bahamut) does not follow the spec (it returns replies in query order instead of chronological order) I added a description of replies, that matches every implementation I could find. In particular, I made it a requirement that `RPL_WHOWASUSER` must come first, because otherwise it would be hell for clients to parse this. Finally, I made it explicit that `RPL_ENDOFWHOWAS` should not be used when the nick is missing, to match existing implementations (as opposed to what the RFCs say).
This was referenced Mar 20, 2022
Closed
progval
added a commit
to progval/irctest
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax and base description are copied from
https://datatracker.ietf.org/doc/html/rfc1459#section-4.5.3
with two changes:
<server>because it is pointless<count>SHOULD be a non-positive number" because oneimplementation (ircu2) does not handle
0the same way others do.(besides, there is no reason for clients to send that)
I ignored https://datatracker.ietf.org/doc/html/rfc2812#section-3.6.3
because noone seems to implement wildcards, and the only implementation
supporting TARGMAX WHOWAS (Bahamut) does not follow the spec (it returns
replies in query order instead of chronological order)
I added a description of replies, that matches every implementation I
could find.
In particular, I made it a requirement that
RPL_WHOWASUSERmust comefirst, because otherwise it would be hell for clients to parse this.
Finally, I made it explicit that
RPL_ENDOFWHOWASshould not be usedwhen the nick is missing, to match existing implementations (as opposed
to what the RFCs say).