Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify reply to invalid PASS. #172

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Specify reply to invalid PASS. #172

merged 2 commits into from
Apr 13, 2022

Conversation

progval
Copy link
Member

@progval progval commented Mar 21, 2022

Closes GH-16.

@emersion
Copy link
Contributor

Hmm. I personally don't send ERROR so that the client can try again.

@progval progval added the feedback wanted We need to make sure this is correct label Mar 22, 2022
emersion
emersion approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@progval progval merged commit ca54667 into ircdocs:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

Assignees
No one assigned
Labels
feedback wanted We need to make sure this is correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PASS: list ERR_PASSWDMISMATCH
2 participants
@progval @emersion