sasl-3.1: add SCRAM and mention that the client must always send a response #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks LGTM. This resolves #325. Holding off on merging until I've reviewed your other edits here https://github.com/grawity/ircv3-specifications/blob/sasl2/extensions/sasl-3.1.md |
|
I added some commit comments on the further edits here: grawity@317c2fa |
progval
added a commit
to progval/irctest
that referenced
this pull request
Nov 15, 2017
|
@grawity any thoughts on the review comments? |
|
The full rewrite is not part of this PR, not sure why it's a blocker... |
|
Fair enough. Could you open a WIP PR for those edits then? |
progval
added a commit
to progval/Limnoria
that referenced
this pull request
Jan 14, 2018
progval
added a commit
to progval/irctest
that referenced
this pull request
Feb 21, 2021
progval
added a commit
to progval/irctest
that referenced
this pull request
Feb 21, 2021
progval
added a commit
to progval/irctest
that referenced
this pull request
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.