-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SETNAME Spec #361
SETNAME Spec #361
Conversation
Nice, I like it. The With servers validating the new realname, if a given realname is too long it feels like the server should probably just silently truncate it, matching what servers already do when getting it initially via If the server would otherwise reject the change (maybe because the client's been changing it too fast, it's being used to bypass a channel ban like how nick changes are restricted, or the value's just bad), it might make sense to explicitly send a response. Maybe a good chance to use the proposed
|
Very simple implementation in BitBot as of bitbot-irc/bitbot@acbe02ba - let me know when there's a test server to try it on |
PR written up for Oragono here, pending the review q above |
Should there be a NAMELEN isupport key? |
"be conservative in what you do, be liberal in what you accept from others."
On how existing impls handle the realname being too long in their current Insp:
Unreal:
So they both explicitly send a notice to the user and fail out, not changing the realname. Cool. |
Does it make sense to call this SETNAME over SETREALNAME or SETGECKOS? When I think of To add on Dan's point: charybdis silently truncates realnames at 32/64 characters I think. |
|
+1 for the command to be |
I'd favour not changing a command that users might be accustomed to just for the sake of it. |
This is now deployed on the IRCCloud client, and our teams/slack/bnc servers. @jesopo you should already have access to the testing team server. |
Looks good to me, nice work. |
Co-Authored-By: justjanne <janne@kuschku.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some change suggestions.
Co-Authored-By: justjanne <janne@kuschku.de>
Co-Authored-By: justjanne <janne@kuschku.de>
Co-Authored-By: justjanne <janne@kuschku.de>
Co-Authored-By: justjanne <janne@kuschku.de>
Co-Authored-By: justjanne <janne@kuschku.de>
Co-Authored-By: justjanne <janne@kuschku.de>
Co-Authored-By: justjanne <janne@kuschku.de>
Co-Authored-By: justjanne <janne@kuschku.de>
Co-Authored-By: justjanne <janne@kuschku.de>
Co-Authored-By: justjanne <janne@kuschku.de>
Co-Authored-By: justjanne <janne@kuschku.de>
Co-Authored-By: justjanne <janne@kuschku.de>
Thanks, this is mergeable as draft now imo. |
In Short
setname
capabilitySETNAME
commandRationale
Realnames have historically been immutable for a connection, which has
historically been accepted, as they were rarely used and usually not as present
in client UIs. Still, multiple IRCds have provided independent, non-standard
commands to update realnames.
Nowadays, multiple clients show realnames directly in chat, next to the nick
name, or use information from the realname to provide enhancements, such as
using emails in the realname to provide gravatar based avatars, leading to
higher demand for this functionality than ever.