Address comments

iree-org · Jun 8, 2023 · f54e50c · f54e50c
1 parent 1148f63
commit f54e50c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/experimental/cuda2/cuda_allocator.c b/experimental/cuda2/cuda_allocator.c
@@ -569,10 +569,10 @@ static iree_status_t iree_hal_cuda2_allocator_import_buffer(
     case IREE_HAL_EXTERNAL_BUFFER_TYPE_OPAQUE_FD:
     case IREE_HAL_EXTERNAL_BUFFER_TYPE_OPAQUE_WIN32:
       return iree_make_status(IREE_STATUS_UNIMPLEMENTED,
-                              "unimplmented handle-based imports");
+                              "handle-based imports not yet implemented");
     default:
       return iree_make_status(IREE_STATUS_UNIMPLEMENTED,
-                              "unimplmented external buffer type");
+                              "external buffer type not supported");
   }
 
   iree_hal_buffer_t* buffer = NULL;
@@ -605,7 +605,7 @@ static iree_status_t iree_hal_cuda2_allocator_export_buffer(
     iree_hal_external_buffer_flags_t requested_flags,
     iree_hal_external_buffer_t* IREE_RESTRICT out_external_buffer) {
   return iree_make_status(IREE_STATUS_UNIMPLEMENTED,
-                          "unimplemented exporting to external buffers");
+                          "exporting to external buffers not supported");
 }
 
 static const iree_hal_allocator_vtable_t iree_hal_cuda2_allocator_vtable = {

diff --git a/experimental/cuda2/cuda_allocator.h b/experimental/cuda2/cuda_allocator.h
@@ -16,8 +16,10 @@
 extern "C" {
 #endif  // __cplusplus
 
-// Create a CUDA allocator that allocates device memory from the given
-// |device| and used in the given |stream|.
+// Creates a CUDA memory allocator.
+// |device| and |stream| will be used for management operations.
+// |pools| provides memory pools that may be shared across multiple allocators
+// and the pointer must remain valid for the lifetime of the allocator.
 iree_status_t iree_hal_cuda2_allocator_create(
     iree_hal_device_t* base_device,
     const iree_hal_cuda2_dynamic_symbols_t* cuda_symbols, CUdevice device,