Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sequencer translation to allow for multiple serialization formats #33

Closed
benvanik opened this issue Oct 13, 2019 · 0 comments
Closed

Refactor sequencer translation to allow for multiple serialization formats #33

benvanik opened this issue Oct 13, 2019 · 0 comments
Labels
enhancement ➕ New feature or request

Comments

@benvanik
Copy link
Collaborator

Right now the sequencer translation always lowers to bytecode. We should be able to emit C code or LLVM IR just as easily from the low-level sequencer dialect. Whether these targets are represented as new dialects (such as LLVM IR) or directly as a serialization mechanism (bytecode, C, etc) varies, so we should probably have both. This may mainly consist of splitting serialization from the translation (as the SPIR-V dialect is split).
@benvanik benvanik added the enhancement ➕ New feature or request label Oct 13, 2019
@benvanik benvanik added this to the Sequencer Codegen milestone Oct 13, 2019
@benvanik benvanik added this to Ideas in Compiler Development via automation Oct 13, 2019
@benvanik benvanik moved this from Ideas to To do in Compiler Development Oct 13, 2019
Compiler Development automation moved this from To do to Done Mar 19, 2020
@benvanik benvanik removed this from Done in Compiler Development Mar 19, 2020
@benvanik benvanik removed this from the Sequencer Codegen milestone Mar 19, 2020
copybara-service bot pushed a commit that referenced this issue Apr 3, 2020
@marbre
CMake: Fix test labels
cc4328c 
Prior to the changes all `_` in the path got replaced with `/`:

Before:
```
  Test  #30: iree/test/e2e/linalg/path:pw_add.mlir.test
  Test  #31: iree/test/e2e/linalg/path:pw_add_mul.mlir.test
  Test  #32: iree/test/e2e/linalg/path:pw_add_multiwg.mlir.test
  Test  #33: iree/test/e2e/linalg/path:reduce.mlir.test

  Test #268: iree/samples/custom/modules:custom_modules_test
  Test #269: iree/samples/custom/modules/dialect/test:conversion.mlir.test
  Test #270: iree/samples/custom/modules/dialect/test:custom_ops.mlir.test
  Test #271: iree/samples/simple/embedding:simple_embedding_test
```

After:
```
  Test  #30: iree/test/e2e/linalg_path:pw_add.mlir.test
  Test  #31: iree/test/e2e/linalg_path:pw_add_mul.mlir.test
  Test  #32: iree/test/e2e/linalg_path:pw_add_multiwg.mlir.test
  Test  #33: iree/test/e2e/linalg_path:reduce.mlir.test

  Test #268: iree/samples/custom_modules:custom_modules_test
  Test #269: iree/samples/custom_modules/dialect/test:conversion.mlir.test
  Test #270: iree/samples/custom_modules/dialect/test:custom_ops.mlir.test
  Test #271: iree/samples/simple_embedding:simple_embedding_test
```

Closes #1360

COPYBARA_INTEGRATE_REVIEW=#1360 from iml130:cmake-test-labels 34dc25d
PiperOrigin-RevId: 304524688
@GMNGeoffrey GMNGeoffrey mentioned this issue Mar 29, 2023
Merged
@dpackwood dpackwood mentioned this issue Sep 8, 2023
Closed
@gabeweisz gabeweisz mentioned this issue Mar 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ➕ New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benvanik