Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get a standard TFLite Android demo application coded against either the C API or JNI running. #3954

Closed
benvanik opened this issue Nov 21, 2020 · 5 comments
Labels
bindings/tflite TensorFlow Lite C API wrapping IREE's C API platform/android 🤖 Android-specific build, execution, benchmarking, and deployment runtime Relating to the IREE runtime library

Comments

@benvanik
Copy link
Collaborator

They have an image classifier demo / info known to work with the GPU models that we will be trying.

It uses their JNI wrapper that we can rip up to start as they include delegates and stuff whereas we just want something that uses the C API.

I think for the sprint we can just fork the whole demo + it's config into experimental/ (changing some things of course ;).

Once we can use vcpkg to build an AAR it'll be much easier to get demos like this stood up, but until then we can just hack the build until it works.

@benvanik benvanik added platform/android 🤖 Android-specific build, execution, benchmarking, and deployment runtime Relating to the IREE runtime library integrations/tensorflow TensorFlow model import and conversion integrations/tflite bindings/tflite TensorFlow Lite C API wrapping IREE's C API and removed integrations/tensorflow TensorFlow model import and conversion integrations/tflite labels Nov 21, 2020
@ScottTodd
Copy link
Member

How do we feel about putting Android app code in IREE's experimental/ vs creating a dedicated iree-samples repository? The Android file paths can get pretty long :P

@benvanik
Copy link
Collaborator Author

I think ideally long-term samples live in their own repo so they can be versioned and don't turn into a monorepo - so google/iree-samples-android/ would have all the copies of gradle jars and icons and xml files and source model files and crap, not our main repo. Short term a single demo could live in google/iree/experimental/, but I'd almost prefer saying that it lives in scotttodd/iree-android-tflite-demo-mumble/ and is something we link to until we want to formalize that. Be agile and such. Even short term we probably shouldn't be in the business of having tflite-based android demos in our repo, and experimental/ would just be for collaboration if it was helpful.

@ScottTodd
Copy link
Member

Agreed. cc @not-jenni + @KoolJBlack

@antiagainst
Copy link
Contributor

I think someday we should have an IREE GitHub organization for hosting various projects. ;-P

@ScottTodd
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings/tflite TensorFlow Lite C API wrapping IREE's C API platform/android 🤖 Android-specific build, execution, benchmarking, and deployment runtime Relating to the IREE runtime library
Projects
None yet
Development

No branches or pull requests

3 participants