Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support flow.tensor.slice and flow.tensor.update during transient allocation #5410

Closed
benvanik opened this issue Apr 13, 2021 · 1 comment
Closed

Support flow.tensor.slice and flow.tensor.update during transient allocation #5410

benvanik opened this issue Apr 13, 2021 · 1 comment
Assignees
@benvanik
Labels
compiler/dialects Relating to the IREE compiler dialects (flow, hal, vm) performance ⚡ Performance/optimization related work across the compiler and runtime

Comments

@benvanik
Copy link
Collaborator

Today both of these ops end up as unique transients and copies during scheduling. Instead they should be checked for during a pre-pass of the stream and added to the coverage map so that they do not get unique buffers allocated to them. This will also allow us to remove the TensorRewriteAdaptor usage from the stream conversion process entirely.

(this is not done as part of the initial #5396 but should be quick to follow up with)
@benvanik benvanik added compiler/dialects Relating to the IREE compiler dialects (flow, hal, vm) performance ⚡ Performance/optimization related work across the compiler and runtime labels Apr 13, 2021
@benvanik benvanik self-assigned this Apr 13, 2021
@benvanik benvanik mentioned this issue Apr 26, 2021
Merged
@benvanik
Copy link
Collaborator Author

Duplicate of #7729.

@benvanik benvanik closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benvanik benvanik

Labels
compiler/dialects Relating to the IREE compiler dialects (flow, hal, vm) performance ⚡ Performance/optimization related work across the compiler and runtime
Projects
No open projects
IREE
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benvanik