Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumb through tensor.pack e2e execution for llvm-cpu backend. #11875

Merged
merged 4 commits into from Feb 9, 2023

Conversation

hanhanW
Copy link
Contributor

@hanhanW hanhanW commented Jan 18, 2023

All the tensor.pack ops with static inner_tile_sizes are vectorized, which are all covered by e2e tests.

@hanhanW hanhanW marked this pull request as ready for review February 6, 2023 02:47
Copy link
Contributor

@MaheshRavishankar MaheshRavishankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this test separate so that it is tested on vmvx path where it is used and vectorization isnt important.

Copy link
Contributor

@MaheshRavishankar MaheshRavishankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Nice! Just a comment on the tests.

@hanhanW
Copy link
Contributor Author

hanhanW commented Feb 9, 2023

Can we make this test separate so that it is tested on vmvx path where it is used and vectorization isnt important.

Supporting the op on VMVX is my next step. Although vectorization is not used on VMVX side, it requires a memref version of pack/unpack. In this PR, I'd like to make sure that tensor version covers all the cases for llvm-cpu side.

I'm preparing a separate PR that will bufferize tensor.pack/unpack into iree_linalg_ext.pack/unpack; will enable the test for vmvx. After that, I'll switch data tiling approach to use tensor.pack/unpack version, and deprecate iree_linalg_ext ops and transforms as much as possible. WDYT?

@MaheshRavishankar
Copy link
Contributor

Can we make this test separate so that it is tested on vmvx path where it is used and vectorization isnt important.

Supporting the op on VMVX is my next step. Although vectorization is not used on VMVX side, it requires a memref version of pack/unpack. In this PR, I'd like to make sure that tensor version covers all the cases for llvm-cpu side.

I'm preparing a separate PR that will bufferize tensor.pack/unpack into iree_linalg_ext.pack/unpack; will enable the test for vmvx. After that, I'll switch data tiling approach to use tensor.pack/unpack version, and deprecate iree_linalg_ext ops and transforms as much as possible. WDYT?

Sounds good!

@hanhanW hanhanW merged commit bd01143 into iree-org:main Feb 9, 2023
@hanhanW hanhanW deleted the tensor-pack-e2e-ver2 branch February 9, 2023 02:38
qedawkins pushed a commit to qedawkins/iree that referenced this pull request Apr 2, 2023
…rg#11875)

All the tensor.pack ops with static inner_tile_sizes are vectorized, which are all covered by e2e tests.
jpienaar pushed a commit that referenced this pull request May 1, 2023
All the tensor.pack ops with static inner_tile_sizes are vectorized, which are all covered by e2e tests.
rengolin pushed a commit to plaidml/iree that referenced this pull request May 2, 2023
…rg#11875)

All the tensor.pack ops with static inner_tile_sizes are vectorized, which are all covered by e2e tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants