[StableHLO][NFC] Factor out and clean up pointwise patterns #13018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is primarily to improve compilation times when iterating on the rest of StableHLO to Linalg conversion patterns. These pointwise patterns create a large number of class template instantiations and take a few seconds to compile. Also clean up the code: - Use free cast functions - Make the conversion patterns final - Prefer static/free helper functions
kuhar
requested review from
MaheshRavishankar and
stellaraccident
as code owners
kuhar
added
the
integrations/stablehlo
ScottTodd
approved these changes
Apr 11, 2023
jpienaar
pushed a commit
that referenced
this pull request
May 1, 2023
This is primarily to improve compilation times when iterating on the rest of StableHLO to Linalg conversion patterns. These pointwise patterns create a large number of class template instantiations and take >20s to compile on my machine. Also clean up the code: - Use free cast functions - Make the conversion patterns final - Prefer static/free helper functions Issue: #12678
NatashaKnk
pushed a commit
to NatashaKnk/iree
that referenced
this pull request
Jul 6, 2023
…#13018) This is primarily to improve compilation times when iterating on the rest of StableHLO to Linalg conversion patterns. These pointwise patterns create a large number of class template instantiations and take >20s to compile on my machine. Also clean up the code: - Use free cast functions - Make the conversion patterns final - Prefer static/free helper functions Issue: iree-org#12678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily to improve compilation times when iterating on the rest of StableHLO to Linalg conversion patterns. These pointwise patterns create a large number of class template instantiations and take >20s to compile on my machine.
Also clean up the code:
Issue: #12678