[StableHLO][NFC] Move pointwise to linalg conversion to source file #13044
+115
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the pointwise StableHLO op to `linalg.generic` conversion out of the common header and to the matching source file. In addition, unify the common precondition checks code used by both pointwise patterns and pull it out to a non-template function. This is to reduce the amount of duplicated code. This reduces the compilation time of this source file from 28s to 22s on my machine. Also clean up the moved pattern. Issue: iree-org#12678
kuhar
requested review from
MaheshRavishankar and
stellaraccident
as code owners
antiagainst
approved these changes
Apr 12, 2023
ScottTodd
approved these changes
Apr 12, 2023
ScottTodd
added
the
integrations/stablehlo
jpienaar
pushed a commit
that referenced
this pull request
May 1, 2023
…13044) This moves the pointwise StableHLO op to `linalg.generic` conversion out of the common header and to the matching source file. In addition, unify the common precondition checks code used by both pointwise patterns and pull it out to a non-template function. This is to reduce the amount of duplicated code. This reduces the compilation time of this source file from 28s to 22s on my machine. Also clean up the moved pattern. Issue: #12678
NatashaKnk
pushed a commit
to NatashaKnk/iree
that referenced
this pull request
Jul 6, 2023
…ree-org#13044) This moves the pointwise StableHLO op to `linalg.generic` conversion out of the common header and to the matching source file. In addition, unify the common precondition checks code used by both pointwise patterns and pull it out to a non-template function. This is to reduce the amount of duplicated code. This reduces the compilation time of this source file from 28s to 22s on my machine. Also clean up the moved pattern. Issue: iree-org#12678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the pointwise StableHLO op to
linalg.genericconversion out of the common header and to the matching source file.In addition, unify the common precondition checks code used by both pointwise patterns and pull it out to a non-template function. This is to reduce the amount of duplicated code. This reduces the compilation time of this source file from 28s to 22s on my machine.
Also clean up the moved pattern.
Issue: #12678