[StableHLO] Port missing pointwise op tests #13052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I went over the list of all pointwise ops that we currently handle. These fell through the cracks during the initial import (iree-org#12957). Two ops are not tested: `ComplexOp` and `NotOp`, but these do not have any tests in mlir-hlo either. Next, I plan to split the linalg lowering tests into a few smaller test files. Issue: iree-org#12678
kuhar
requested review from
MaheshRavishankar and
stellaraccident
as code owners
kuhar
changed the title
|
(driveby: running |
Yeah these tests have other issues too, e.g., check match variable scope has to be disabled, but I'm trying not to change too many things at once and, instead, make it more manageable in simple increments. |
ScottTodd
approved these changes
Apr 12, 2023
jpienaar
pushed a commit
that referenced
this pull request
May 1, 2023
I went over the list of all pointwise ops that we currently handle. These fell through the cracks during the initial import (#12957). Two ops are not tested: `ComplexOp` and `NotOp`, but these do not have any tests in mlir-hlo either. Next, I plan to split the linalg lowering tests into a few smaller test files. Issue: #12678
NatashaKnk
pushed a commit
to NatashaKnk/iree
that referenced
this pull request
Jul 6, 2023
I went over the list of all pointwise ops that we currently handle. These fell through the cracks during the initial import (iree-org#12957). Two ops are not tested: `ComplexOp` and `NotOp`, but these do not have any tests in mlir-hlo either. Next, I plan to split the linalg lowering tests into a few smaller test files. Issue: iree-org#12678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went over the list of all pointwise ops that we currently handle. These fell through the cracks during the initial import (#12957).
Two ops are not tested:
ComplexOpandNotOp, but these do not have any tests in mlir-hlo either.Next, I plan to split the linalg lowering tests into a few smaller test files.
Issue: #12678