Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StableHLO] Add broadcast_in_dim canon patterns #13746

Merged
merged 1 commit into from
May 23, 2023
Merged

[StableHLO] Add broadcast_in_dim canon patterns #13746

merged 1 commit into from
May 23, 2023

Conversation

kuhar
Copy link
Member

@kuhar kuhar commented May 23, 2023

These are based on the equivalent fold and canonicalizer from MHLO.

Also run stablehlo canonicalization pass between other lowering passes.

Issue: #12678

@kuhar
[StableHLO] Add broadcast_in_dim canon patterns
e386b7b 
These are based on the equivalent fold and canonicalizer from MHLO.

Issue: iree-org#12678
benvanik
benvanik approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@benvanik benvanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may want to see if wrapping the canonicalize + hlo canonicalize + cse sequence in a IREE::Util::createFixedPointIteratorPass helps real models if there are cases where patterns in the HLO canonicalization may enable patterns in the standard one.

@kuhar
Copy link
Member Author

kuhar commented May 23, 2023

we may want to see if wrapping the canonicalize + hlo canonicalize + cse sequence in a IREE::Util::createFixedPointIteratorPass helps real models if there are cases where patterns in the HLO canonicalization may enable patterns in the standard one.

Good idea. I'll do that if I find an input that requires these to run more than once.

@kuhar kuhar merged commit fa9ac42 into iree-org:main May 23, 2023
49 checks passed
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this pull request Jul 6, 2023
@kuhar @NatashaKnk
[StableHLO] Add broadcast_in_dim canon patterns (iree-org#13746)
76738ab 
These are based on the equivalent fold and canonicalizer from MHLO.

Also run stablehlo canonicalization pass between other lowering passes. 

Issue: iree-org#12678
nhasabni pushed a commit to plaidml/iree that referenced this pull request Aug 24, 2023
@kuhar @nhasabni
[StableHLO] Add broadcast_in_dim canon patterns (iree-org#13746)
e2f3b70 
These are based on the equivalent fold and canonicalizer from MHLO.

Also run stablehlo canonicalization pass between other lowering passes. 

Issue: iree-org#12678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benvanik benvanik benvanik approved these changes

@antiagainst antiagainst Awaiting requested review from antiagainst

@ScottTodd ScottTodd Awaiting requested review from ScottTodd

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar MaheshRavishankar is a code owner

@stellaraccident stellaraccident Awaiting requested review from stellaraccident stellaraccident is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuhar @benvanik