Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StableHLO] Port gather canonicalization pattern #13771

Merged
merged 1 commit into from
May 24, 2023
Merged

[StableHLO] Port gather canonicalization pattern #13771

merged 1 commit into from
May 24, 2023

Conversation

kuhar
Copy link
Member

@kuhar kuhar commented May 24, 2023

This pattern folds gather into slice (+ reshape) and is ported from MHLO.

Issue: #12678

@kuhar
[StableHLO] Port gather canonicalization pattern
e54096f 
This pattern folds gather into slice (+ reshape) and is ported from
MHLO.

Issue: iree-org#12678
@kuhar
Copy link
Member Author

kuhar commented May 24, 2023

Not sure why the windows runtime tests failed:

[ RUN      ] LoopTest.WaitAnyBlocking
C:\a\iree\iree\runtime\src\iree/base/loop_test.h(795): error: Value of: status
Expected: error code OK
  Actual: 0000000000000004, whose error code is DEADLINE_EXCEEDED: DEADLINE_EXCEEDED

Have we seen this before @benvanik @ScottTodd?

@ScottTodd
Copy link
Member

Not sure why the windows runtime tests failed:

[ RUN      ] LoopTest.WaitAnyBlocking
C:\a\iree\iree\runtime\src\iree/base/loop_test.h(795): error: Value of: status
Expected: error code OK
  Actual: 0000000000000004, whose error code is DEADLINE_EXCEEDED: DEADLINE_EXCEEDED

Have we seen this before @benvanik @ScottTodd?

Haven't seen that before, no. Unrelated to your PR though... maybe just re-run the failed job?

@kuhar kuhar merged commit 9067fc9 into iree-org:main May 24, 2023
48 checks passed
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this pull request Jul 6, 2023
@kuhar @NatashaKnk
[StableHLO] Port gather canonicalization pattern (iree-org#13771)
ebad8bd 
This pattern folds gather into slice (+ reshape) and is ported from
MHLO.

Issue: iree-org#12678
nhasabni pushed a commit to plaidml/iree that referenced this pull request Aug 24, 2023
@kuhar @nhasabni
[StableHLO] Port gather canonicalization pattern (iree-org#13771)
162d458 
This pattern folds gather into slice (+ reshape) and is ported from
MHLO.

Issue: iree-org#12678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiagainst antiagainst antiagainst approved these changes

@ScottTodd ScottTodd ScottTodd approved these changes

@benvanik benvanik Awaiting requested review from benvanik

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar MaheshRavishankar is a code owner

@stellaraccident stellaraccident Awaiting requested review from stellaraccident stellaraccident is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kuhar @ScottTodd @antiagainst