[cuda] Port over allocator and buffer implementation #13985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiagainst
force-pushed
the
cuda2-allocator
branch
from
8d35942
to
6c237e7
Compare
|
@benvanik: The first commit is just copying code. My modification happens in the second commit. I figured this way it might make the review easiser. |
|
Nice! If you could, I'd recommend taking #13440 as the base instead - that has some non-trivial changes that will be harder to port on top of your changes here without just deleting these files. You could replace your base commit doing the copy with the files from the PR and then try rebasing your second commit on top of it (or just find/replace again). That PR is ready to land if we disabled the two tests suites testing graphs - the followup that hacks the memsets will happen tonight but neither should block you taking a copy of them. |
|
SG! Let me include the new changes you made there then. |
antiagainst
force-pushed
the
cuda2-allocator
branch
from
6c237e7
to
311fe45
Compare
This commit ports over existing CUDA driver allocator and buffer implementation. The main logic is kept as-is, with one noticeable changes--context wrapper is dropped and fields in it are directly put in various API calls. This is to make supporting multiple device and stream easier later. Other changes are just polishing on comments and errors.
antiagainst
force-pushed
the
cuda2-allocator
branch
from
311fe45
to
1148f63
Compare
benvanik
requested changes
Jun 8, 2023
benvanik
requested changes
Jun 8, 2023
benvanik
approved these changes
Jun 8, 2023
NatashaKnk
pushed a commit
to NatashaKnk/iree
that referenced
this pull request
Jul 6, 2023
This commit ports over existing CUDA driver allocator and buffer implementation. The main logic is kept as-is, with one noticeable changes--context wrapper is dropped and fields in it are directly put in various API calls. This is to make supporting multiple device and stream easier later. Other changes are just polishing on comments and errors. Progress towards iree-org#13245
nhasabni
pushed a commit
to plaidml/iree
that referenced
this pull request
Aug 24, 2023
This commit ports over existing CUDA driver allocator and buffer implementation. The main logic is kept as-is, with one noticeable changes--context wrapper is dropped and fields in it are directly put in various API calls. This is to make supporting multiple device and stream easier later. Other changes are just polishing on comments and errors. Progress towards iree-org#13245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ports over existing CUDA driver allocator and buffer
implementation. The main logic is kept as-is, with one noticeable
changes--context wrapper is dropped and fields in it are directly
put in various API calls. This is to make supporting multiple
device and stream easier later. Other changes are just polishing
on comments and errors.
Progress towards #13245