Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MHLO support #14008

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Remove MHLO support #14008

merged 1 commit into from
Jun 12, 2023

Conversation

kuhar
Copy link
Member

@kuhar kuhar commented Jun 8, 2023

Drop the MHLO input conversion pipeline, which has been deprecated for over a week. The StableHLO pipeline is the direct replacement. See the announcement thread for more context:
https://groups.google.com/g/iree-discuss/c/s6dBpDtWhtk.

This still uses the copy of stablehlo from the mlir-hlo repo -- we will switch to the stablehlo repo in a follow-up PR.

Issue: #12678

@kuhar kuhar changed the title Remove MHLO support [DNS] Remove MHLO support Jun 8, 2023
antiagainst
antiagainst approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@antiagainst antiagainst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@kuhar
Copy link
Member Author

kuhar commented Jun 8, 2023

(I plan to submit this PR on Monday, unless something comes up, just like we announced on iree-discuss and openxa-discuss.)

@kuhar kuhar added the integrations/stablehlo StableHLO (JAX/TensorFlow/etc) import and conversion label Jun 9, 2023
ScottTodd
ScottTodd approved these changes Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the mlir-hlo submodule be removed after this too?

@GMNGeoffrey
Copy link
Contributor

This still uses the copy of stablehlo from the mlir-hlo repo -- we will switch to the stablehlo repo in a follow-up PR.

😛

@ScottTodd
Copy link
Collaborator

Oh, I can't read. Thanks :P

@kuhar kuhar changed the title [DNS] Remove MHLO support Remove MHLO support Jun 12, 2023
@kuhar
Copy link
Member Author

kuhar commented Jun 12, 2023

Rebased.

@jpienaar
Copy link
Member

Was the regressions in JAX tests addressed?

@kuhar
Copy link
Member Author

kuhar commented Jun 12, 2023 •
edited
Loading

@jpienaar Which one? I don't see any unresolved issues in my queue.

@jpienaar
Copy link
Member

@rsuderman was there an issue tracking those?

@kuhar
Remove MHLO support
9b7d3c5 
Drop the MHLO input conversion pipeline, which has been deprecated for
over a week. The StableHLO pipeline is the direct replacement. See the
announcement thread for more context:
https://groups.google.com/g/iree-discuss/c/s6dBpDtWhtk.

This still uses the copy of stablehlo from the mlir-hlo repo -- we will
switch to the stablehlo repo in a follow-up PR.

Issue: iree-org#12678
@kuhar
Copy link
Member Author

kuhar commented Jun 12, 2023

Rebased.

@kuhar
Copy link
Member Author

kuhar commented Jun 12, 2023

@rsuderman was there an issue tracking those?

I asked Rob offline and he gave this PR a green light:

Make the switch over, while I have bandwidth I am going to keep hammering through the test suite and finding issues.
No its fine at this point. I am going to hopefully get stuff fixed this week from the migration

@kuhar kuhar merged commit 0dbf086 into iree-org:main Jun 12, 2023
48 checks passed
nhasabni pushed a commit to plaidml/iree that referenced this pull request Aug 24, 2023
@kuhar @nhasabni
Remove MHLO support (iree-org#14008)
3d8b063 
Drop the MHLO input conversion pipeline, which has been deprecated for
over a week. The StableHLO pipeline is the direct replacement. See the
announcement thread for more context:
https://groups.google.com/g/iree-discuss/c/s6dBpDtWhtk.

This still uses the copy of stablehlo from the mlir-hlo repo -- we will
switch to the stablehlo repo in a follow-up PR.

Issue: iree-org#12678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiagainst antiagainst antiagainst approved these changes

@ScottTodd ScottTodd ScottTodd approved these changes

@benvanik benvanik Awaiting requested review from benvanik benvanik is a code owner

@stellaraccident stellaraccident Awaiting requested review from stellaraccident stellaraccident is a code owner

@jpienaar jpienaar Awaiting requested review from jpienaar

@rsuderman rsuderman Awaiting requested review from rsuderman

@hanhanW hanhanW Awaiting requested review from hanhanW hanhanW is a code owner

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar MaheshRavishankar is a code owner

@GMNGeoffrey GMNGeoffrey Awaiting requested review from GMNGeoffrey

@pzread pzread Awaiting requested review from pzread

Assignees
No one assigned
Labels
integrations/stablehlo StableHLO (JAX/TensorFlow/etc) import and conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kuhar @GMNGeoffrey @ScottTodd @jpienaar @antiagainst