[StableHLO] Port reduce canon patterns #14045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that linalg lowering depends on these. The code is ported from equivalent folds and rewrite patterns in the mlir-hlo repo. Fixes: iree-org#14042 Issue: iree-org#12678
kuhar
requested review from
MaheshRavishankar and
stellaraccident
as code owners
benvanik
approved these changes
Jun 10, 2023
nhasabni
pushed a commit
to plaidml/iree
that referenced
this pull request
Aug 24, 2023
Turns out that linalg lowering depends on these. The code is ported from equivalent folds and rewrite patterns in the mlir-hlo repo. The only notable difference is that this implementation fixes bugs with rewrite patterns performing op updates without going through the pattern rewriter. Also added a new test for the second noop case. Fixes: iree-org#14042 Issue: iree-org#12678
stellaraccident
pushed a commit
that referenced
this pull request
Sep 24, 2023
* iree: 651630e [StableHLO] Port reduce canon patterns (#14045) (Sat Jun 10 03:34:46 2023 +0000) * xla: f920496e1 PR #3483: [ROCm] Added to create streams with different priorities (Sat Jun 10 01:59:06 2023 -0700) * jax: 1a7336d44 Remove the monkey patch in jax2tf by moving the function to mlir.py (Fri Jun 9 23:47:20 2023 -0700)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that linalg lowering depends on these.
The code is ported from equivalent folds and rewrite patterns in the mlir-hlo repo. The only notable difference is that this implementation fixes bugs with rewrite patterns performing op updates without going through the pattern rewriter. Also added a new test for the second noop case.
Fixes: #14042
Issue: #12678